1580093 - Add 'ca-valencia' to product-details

Status: RESOLVED INVALID

(Release Engineering :: Applications: Shipit, task)

Description

[Francesco Lodolo [:flod]]

We need to add 'ca-valencia' to the Firefox Nightly l10n builds on mozilla.org:

• Locale needs to be added to the list of supported Nightly locales.
• If missing, add an entry in languages.json with both the English and localized name for this locale.

P.S. To be clear to the localization team, this bug is handled by Mozilla staff.

Comment 1

[Francesco Lodolo [:flod]]

@Rok
Johan directed me to you on IRC.

In the past, we had to manually add Nightly locales to Ship-It (example), in order for the language to be available in product-details, and therefore in mozilla.org.

I looked at the new Ship-It code, and I can't find any reference to Nightly locales anymore.

Do I still need to manually add locales? If so, where?

Comment 2

[Rok Garbas [:garbas]]

as :tomprince mentioned on irc, the code that fetches l10n lived here.

As you can see in the above reference function we fetched locales from tree and in order to add new locale you need to update those locations in-tree.

Comment 3

[Francesco Lodolo [:flod]]

Thanks. The locale was just added, we should have nightly builds in the next day or so. I'll keep this one open to verify that it shows up, then close the bug and update our documentation.

Comment 4

[Francesco Lodolo [:flod]]

l10n-changesets: https://hg.mozilla.org/mozilla-central/rev/ce04e402c705c8ee9d491c3cef11a3876af2680f
builds available in http://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central-l10n/

Still nothing on mozilla.org, but I'm sure there's a lot of caching in-between.

Side question: how are language names managed, i.e. how do I change an existing one, or add it? The code seems to reference languages.json from product-details, but I would expect this to be the source for that…

Comment 5

[Francesco Lodolo [:flod]]

The build is available on mozilla.org, so the system is working. That's a great change, no more manual lists.
https://www.mozilla.org/firefox/nightly/all/?q=valencia

Can you give me any pointer on how to update languages.json in product-details? In this specific case, I would need to change the capitalization, but I'll have another locale to add soon.

Comment 6

[Rok Garbas [:garbas]]

:flod languages.json is actually taken from previously generated product details. you can edit the language here and send PR. then next time product details is generated it will include it.

it would actually be nice to have this languages file somewhere else then here.

Comment 7

[Francesco Lodolo [:flod]]

(In reply to Rok Garbas [:garbas] from comment #6)

:flod languages.json is actually taken from previously generated product details. you can edit the language here and send PR. then next time product details is generated it will include it.

Thanks, I'll close this bug and open a PR there.

it would actually be nice to have this languages file somewhere else then here.

Not exactly sure where it could live. For sure, I know at least two places where this list is duplicated, likely with differences at this point (the other being AMO).

Comment 8

[Francesco Lodolo [:flod]]

Closing as invalid, since Ship It now gets new languages automatically.