Closed Bug 1580172 Opened 2 years ago Closed 2 years ago

[FxA] The FxA menu from the toolbar is not displayed correctly if the Mac OS is in Dark mode


(Firefox :: Firefox Accounts, defect, P2)




Firefox 71
Tracking Status
firefox70 --- wontfix
firefox71 --- verified


(Reporter: Ovidiu, Assigned: vbudhram)



(Whiteboard: [skyline][fxa])


(3 files)

Affected versions

  • Tested on FF Nightly 71.0a1(2019-09-09) and FF Beta 70.0b5

Affected platforms

  • Tested on Mac OS X 10.14, and Mac OS X 10.15 beta version

Steps to reproduce

Prerequisites: Activate the dark mode on Mac (this feature is available only from 10.14 and up versions): Open System Preferences -> General -> From Appearance select "Dark"
Don't log into Sync


  1. Open Firefox and click on the FxA icon from the toolbar
  2. Please observe the "Send Tab to Device", "Connect another device", "Sync Now..." buttons

Expected result

  • The "Send Tab to Device", "Connect another device", "Sync Now..." buttons should be greyed out.

Actual result

  • The "Send Tab to Device", "Connect another device", "Sync Now..." buttons are displayed as being active.

Please see the attached print-screen for a better understanding.

Assignee: nobody → vbudhram

The priority flag is not set for this bug.
:markh, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(markh)
Whiteboard: [skyline] → [skyline][fxa]
Flags: needinfo?(markh)
Priority: -- → P2

I'm taking the P2 as "not a blocker for Skyline/70". We should likely fix this in 71 though.

Pushed by
Fix Fxa CAD button in dark mode theme r=markh
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

I verified this issue on Mac OS X10.14 with FF Nightly 71.0a1(2019-10-11) and the inactive buttons look are the same if the theme is dark or light.


Is this something that needs an uplift to Fx70 for Skyline? If so, please nominate ASAP since the RC build is Monday.

Flags: needinfo?(vbudhram)

Beta/Release Uplift Approval Request

  • User impact if declined: Connect another device button (in fxa menu) does not look disabled in dark mode.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This change is not risky because it only changes the color of the button in dark mode.
  • String changes made/needed:
Flags: needinfo?(vbudhram)
Attachment #9100873 - Flags: approval-mozilla-beta?
Attachment #9099398 - Flags: approval-mozilla-beta?

Hey :ryanvm,

Not sure if this is too late, but the patch is pretty trivial and would be nice to have uplifted. Thank you!

Comment on attachment 9099398 [details]
Bug 1580172 - Fix Fxa CAD button in dark mode theme

Just a little bit too late for 70 as the release candidate build will be today, but this fix should be in 71.

Attachment #9099398 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Attachment #9100873 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
You need to log in before you can comment on or make changes to this bug.