[FxA] The FxA menu from the toolbar is not displayed correctly if the Mac OS is in Dark mode
Categories
(Firefox :: Firefox Accounts, defect, P2)
Tracking
()
People
(Reporter: Ovidiu, Assigned: vbudhram)
References
Details
(Whiteboard: [skyline][fxa])
Attachments
(3 files)
64.92 KB,
image/png
|
Details | |
47 bytes,
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta-
|
Details | Review |
514 bytes,
patch
|
lizzard
:
approval-mozilla-beta-
|
Details | Diff | Splinter Review |
Affected versions
- Tested on FF Nightly 71.0a1(2019-09-09) and FF Beta 70.0b5
Affected platforms
- Tested on Mac OS X 10.14, and Mac OS X 10.15 beta version
Steps to reproduce
Prerequisites: Activate the dark mode on Mac (this feature is available only from 10.14 and up versions): Open System Preferences -> General -> From Appearance select "Dark"
Don't log into Sync
Steps:
- Open Firefox and click on the FxA icon from the toolbar
- Please observe the "Send Tab to Device", "Connect another device", "Sync Now..." buttons
Expected result
- The "Send Tab to Device", "Connect another device", "Sync Now..." buttons should be greyed out.
Actual result
- The "Send Tab to Device", "Connect another device", "Sync Now..." buttons are displayed as being active.
Please see the attached print-screen for a better understanding.
Reporter | ||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 1•5 years ago
|
||
The priority flag is not set for this bug.
:markh, could you have a look please?
For more information, please visit auto_nag documentation.
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 2•5 years ago
|
||
I'm taking the P2 as "not a blocker for Skyline/70". We should likely fix this in 71 though.
Assignee | ||
Comment 3•5 years ago
|
||
Comment 5•5 years ago
|
||
bugherder |
Reporter | ||
Comment 6•5 years ago
|
||
I verified this issue on Mac OS X10.14 with FF Nightly 71.0a1(2019-10-11) and the inactive buttons look are the same if the theme is dark or light.
Comment 7•5 years ago
|
||
Is this something that needs an uplift to Fx70 for Skyline? If so, please nominate ASAP since the RC build is Monday.
Assignee | ||
Comment 8•5 years ago
|
||
Beta/Release Uplift Approval Request
- User impact if declined: Connect another device button (in fxa menu) does not look disabled in dark mode.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This change is not risky because it only changes the color of the button in dark mode.
- String changes made/needed:
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 9•5 years ago
|
||
Hey :ryanvm,
Not sure if this is too late, but the patch is pretty trivial and would be nice to have uplifted. Thank you!
Comment 10•5 years ago
|
||
Comment on attachment 9099398 [details]
Bug 1580172 - Fix Fxa CAD button in dark mode theme
Just a little bit too late for 70 as the release candidate build will be today, but this fix should be in 71.
Updated•5 years ago
|
Updated•5 years ago
|
Description
•