1580188 - Not all search matches are highlighted

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

It looks like that not all search matches are highlighted in the Search panel. See the attached screenshot

• Only the first two search results have highlighted the search-keyword
• The fourth and fifth results don't highlighted anything
• The third result is there because match was with the Cookie name also not highlighted.

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@Lloan, could you please look at this one?
Honza

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

It somehow relates to the fact the the search-string is at the begginning of a cookie (or header) value.
So, the start index is 0, which if used in a condition might be resulting with false even if it's
valid index. Or something like that...

I found this place. Fixing that helps, but not sure if it's the only place...

diff --git a/devtools/client/netmonitor/src/components/search/SearchPanel.js b/devtools/client/netmonitor/src/compo--- a/devtools/client/netmonitor/src/components/search/SearchPanel.js
+++ b/devtools/client/netmonitor/src/components/search/SearchPanel.js
@@ -163,17 +163,17 @@ class SearchPanel extends Component {
       }

       const indexStart = caseSensitive
         ? object.value.indexOf(query)
         : object.value.toLowerCase().indexOf(query.toLowerCase());
       const indexEnd = indexStart + query.length;

       // Handles a match in a string
-      if (indexStart > 0) {
+      if (indexStart >= 0) {
         return span(
           { title: object.value },
           span({}, object.value.substring(0, indexStart)),
           span(
             { className: "query-match" },
             object.value.substring(indexStart, indexStart + query.length)
           ),
           span({}, object.value.substring(indexEnd, object.value.length))

Honza

Comment 3

[lloan alas:[lloanalas]]

Honza,

That should be the only place. I see the error now - its not taking in to account when the index starts at 0. I'll create a patch for this - thanks!

Comment 4

[lloan alas:[lloanalas]]

Attachment: Bug 1580188 - Not all search matches are highlighted. r=honza

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: image.png

Check out the following match at the screenshot:

MyCustomCookie: Workers+eat+cookies

The Workers part isn't highlighted.

Honza

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e329466ec57
Not all search matches are highlighted. r=Honza

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/1e329466ec57