Closed
Bug 1580192
Opened 6 years ago
Closed 6 years ago
Incorrect error check calculating debugger sweep group edges
Categories
(Core :: JavaScript: GC, defect, P1)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla71
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
Sadly I got the condition the wrong way round in DebugAPI::findSweepGroupEdges in bug bug 1564178.
|
Assignee | |
Comment 1•6 years ago
|
||
While this is annoying, I don't think it lead to us getting anything wrong. Rather, grouping zones for sweeping would fail when the debugger was in use and we would fall back to sweeping all zones in one group. So this might have contributed to more jank while collecting when the debugger was in use.
|
|
Assignee | |
Comment 2•6 years ago
|
||
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/06f990600389
Fix error check in calculating debugger sweep group edges r=sfink
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
|
||
Updated•4 years ago
|
Has Regression Range: --- → yes
|
||
Updated•4 years ago
|
Keywords: regression
You need to log in
before you can comment on or make changes to this bug.
Description
•