1580274 - Remove "ip" from proxy.json

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, task)

Description

[Rob Wu [:robwu]]

When proxy.onRequest was implemented (bug 1409878), its details were mostly copied from the webRequest API.

One of the fields in schemas/proxy.json is "ip", which is supposedly "The server IP address that the request was actually sent to."

This field is not set in the implementation, and it couldn't be because the IP cannot be known before a connection is made to a server, and the proxy.onRequest event is fired before that.

So "ip" should be removed from https://searchfox.org/mozilla-central/rev/588814f2edddf0e132d77d326ddae50911e8bad1/toolkit/components/extensions/schemas/proxy.json#159

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1580274 remove unused ip value from proxy schema

Comment 3

[Shane Caraveo (:mixedpuppy)]

verify "ip" is not a part of details for proxy.onRequest in MDN docs.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0cfaf6add1db
remove unused ip value from proxy schema r=robwu

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0cfaf6add1db

Comment 6

[Alex Cornestean]

Hello,

Will this fix require manual validation? If yes, please provide some steps to reproduce in order to correctly test it and also, please set the "qe-verify+" flag. Otherwise, could the "qe-verify-" flag be added? Thanks!

Comment 7

[Richard Bloor]

“ip” is removed from proxy.RequestDetails. Could you review and confirm that this fulfills the documentation needed request? However, I noticed that the proxy.json definition included "urlClassification", does this need to be added to proxy.RequestDetails?

Comment 8

[Shane Caraveo (:mixedpuppy)]

urlClassification is privileged, bug 1589494 is for making it public and it would be documented on that happening.