Remove "ip" from proxy.json
Categories
(WebExtensions :: Request Handling, task)
Tracking
(firefox71 fixed)
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: robwu, Assigned: mixedpuppy)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
When proxy.onRequest
was implemented (bug 1409878), its details were mostly copied from the webRequest API.
One of the fields in schemas/proxy.json is "ip", which is supposedly "The server IP address that the request was actually sent to."
This field is not set in the implementation, and it couldn't be because the IP cannot be known before a connection is made to a server, and the proxy.onRequest
event is fired before that.
So "ip"
should be removed from https://searchfox.org/mozilla-central/rev/588814f2edddf0e132d77d326ddae50911e8bad1/toolkit/components/extensions/schemas/proxy.json#159
Comment 1•5 years ago
|
||
Bugbug thinks this bug should belong to this component, but please revert this change in case of error.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Comment 3•5 years ago
|
||
verify "ip" is not a part of details for proxy.onRequest in MDN docs.
Pushed by scaraveo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0cfaf6add1db remove unused ip value from proxy schema r=robwu
Comment 5•5 years ago
|
||
bugherder |
Comment 6•5 years ago
|
||
Hello,
Will this fix require manual validation? If yes, please provide some steps to reproduce in order to correctly test it and also, please set the "qe-verify+" flag. Otherwise, could the "qe-verify-" flag be added? Thanks!
Assignee | ||
Updated•5 years ago
|
Comment 7•5 years ago
|
||
“ip” is removed from proxy.RequestDetails. Could you review and confirm that this fulfills the documentation needed request? However, I noticed that the proxy.json
definition included "urlClassification", does this need to be added to proxy.RequestDetails?
Assignee | ||
Comment 8•5 years ago
|
||
urlClassification is privileged, bug 1589494 is for making it public and it would be documented on that happening.
Updated•5 years ago
|
Description
•