1580278 - Align Ellipsis Menu Styling to New Tab Spec

Status: NEW

(Firefox :: about:logins, enhancement, P3)

Description

[rgaddis]

Attachment: side-by-side comparison

This bug accounts for aligning our Ellipsis menu to the one found within New Tab (see attachment for side-by-side comparison)

This involves the (at least) following changes:

• changing default fill of ellipsis svg to #737373
• changing hover/active of menu to #0C0C0D
• Removing the bounding box/button background from our menu
• Adjusting box shadow of menu to match: 0 5px 10px rgba(0, 0, 0, 0.3), 0 0 0 1px rgba(0, 0, 0, 0.2)
• Adjusting section separators to match New Tab menu: 1px
• Adjusting background of menu (var(--newtab-contextmenu-background-color))
• Adjusting font-size of menu items: 14 instead of 15

Comment 1

[Matthew N. [:MattN]]

Mass removing [skyline] and [passwords:management] from about:logins bugs which are no longer useful.

Comment 2

[Maxx Crawford [:maxx]]

Created attachment 9091843 [details]
side-by-side comparison

This bug accounts for aligning our Ellipsis menu to the one found within New Tab (see attachment for side-by-side comparison)

This involves the (at least) following changes:

• changing default fill of ellipsis svg to #737373
• changing hover/active of menu to #0C0C0D
• Removing the bounding box/button background from our menu
• Adjusting box shadow of menu to match: 0 5px 10px rgba(0, 0, 0, 0.3), 0 0 0 1px rgba(0, 0, 0, 0.2)
• Adjusting section separators to match New Tab menu: 1px
• Adjusting background of menu (var(--newtab-contextmenu-background-color))
• Adjusting font-size of menu items: 14 instead of 15

Ryan – Could provide dark-mode specs as well? Some of these don't have a dark mode counter part. Changing what I can beyond that!

Comment 3

[rgaddis]

In the past, I believe dark mode handling has largely been supported somewhat automagically based on how the light-mode colors are set, rather than setting specific dark-mode specs. Jaws, please correct me if I'm wrong.

Comment 4

[Matthew N. [:MattN]]

Rather than replicate the styling, I think Mark was looking at sharing the menu component so it can also be used on about:addons. Mark, what's the status of that?

Bug 1615938 is a small P2 bug that you could work on in the meantime. Same with bug 1615215.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Yes, Ryan is correct. We should use the existing variables where possible, and if not available we should add new ones and update both components to use them (or file a bug at least for the New Tab page to use the new variables).