Remove nsIX509CertList from TransportSecurityInfo
Categories
(Core :: Security: PSM, enhancement, P1)
Tracking
()
People
(Reporter: sefeng, Assigned: sefeng)
References
Details
(Whiteboard: [psm-assigned])
Attachments
(2 files, 4 obsolete files)
Assignee | ||
Comment 1•5 years ago
|
||
Since we are removing nsIX509CertList, some of the helper functions
need to be duplicated with small modifications to adapt the new
certList format.
Assignee | ||
Comment 2•5 years ago
|
||
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
This patch intends to change the internal reprensentation of certList
from nsIX509CertList to Array for TransportSecurityInfo.
Assignee | ||
Comment 4•5 years ago
|
||
Depends on D48744
Assignee | ||
Comment 5•5 years ago
|
||
Some glue code was introduced when we converted certChain in
TransportSecurityInfo from nsIX509CertList to Array.
This patch intends to remove them.
Depends on D48745
Assignee | ||
Updated•5 years ago
|
Pushed by sefeng@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c770a884ed23 Change certList internal representation to Array r=keeler
Assignee | ||
Comment 7•5 years ago
|
||
The internal representation of certList has been converted to
cert array, and this patch does it for the serialization.
Comment 8•5 years ago
|
||
bugherder |
Pushed by sefeng@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d3482abe1fc9 Use cert array to do certList serialization r=keeler
Comment 10•5 years ago
|
||
bugherder |
Comment 11•5 years ago
|
||
Pushed by sefeng@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/11e5baee978e Convert certList to raw array for nsITransportSecurityInfo r=keeler,Ehsan,kershaw
Comment 12•5 years ago
|
||
Backout by malexandru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b064c734e317 Backed out changeset 11e5baee978e for issues related to certList. CLOSED TREE
Comment 13•5 years ago
|
||
Backed out changeset 11e5baee978e (Bug 1580315) for issues related to certList.
Backout link: https://hg.mozilla.org/integration/autoland/rev/b064c734e317213d45d79e7c7bee49f34f4aebf7
Failure logs:
- TypeError: this.secInfo is undefined at _hasCustomRoot@chrome://browser/content/browser-siteIdentity.js:681:1
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272248676&repo=autoland&lineNumber=2077 - Uncaught exception - TypeError: certificateSection.shadowRoot.querySelector(...) is null
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272248807&repo=autoland&lineNumber=3245 - ev-test.example.com should not have succeededCertChain set - false == true
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272248780&repo=autoland&lineNumber=2534 - details pane: should have the expected number of cert names - 0 == 1 - JS frame :: chrome://mochitests/content/browser/security/manager/ssl/tests/mochitest/browser/browser_certViewer.js :: checkDetailsPane :: line 391
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272248338&repo=autoland&lineNumber=795
Comment 14•5 years ago
|
||
Seems to also be causing timeouts like these:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272248309&repo=autoland&lineNumber=795
Comment 15•5 years ago
|
||
Alexandry, if I read this bug correctly, this landed in 71 nightly just before the merge and was backed out after the merge in 72 nightly. If it's not good enough for nightly to deserve a back out, shouldn't it be backed out from beta as well?
Comment 16•5 years ago
|
||
Well as far as I can see d3482abe1fc9 was the latest changeset from this bug to make it into beta, and that one didn't give us any trouble on nightly,
so I don't think we should back it out from beta.
11e5baee978e was backed out before getting into central, so that one didn't make it into beta.
Comment 17•5 years ago
|
||
Comment on attachment 9099972 [details]
Bug 1580315 - Convert certList to raw array for nsITransportSecurityInfo
Revision D48745 was moved to bug 1592083. Setting attachment 9099972 [details] to obsolete.
Assignee | ||
Comment 18•5 years ago
|
||
Created bug 1592083 for the rest of the TransportSecurityInfo changes to make this bug can be marked as resolved.
Updated•5 years ago
|
Description
•