1580315 - Remove nsIX509CertList from TransportSecurityInfo

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P1)

Comment 1

[Sean Feng [:sefeng211]]

Attachment: Bug 1580315 - Duplicate some helper functions from nsIX509CertList r=keeler

Since we are removing nsIX509CertList, some of the helper functions
need to be duplicated with small modifications to adapt the new
certList format.

Comment 2

[Sean Feng [:sefeng211]]

Attachment: Bug 1580315 - Remove nsIX509CertList from TransportSecurityInfo r=keeler

Comment 3

[Sean Feng [:sefeng211]]

Attachment: Bug 1580315 - Change certList internal representation to Array

This patch intends to change the internal reprensentation of certList
from nsIX509CertList to Array for TransportSecurityInfo.

Comment 4

[Sean Feng [:sefeng211]]

Attachment: Bug 1580315 - Convert certList to raw array for nsITransportSecurityInfo

Depends on D48744

Comment 5

[Sean Feng [:sefeng211]]

Attachment: Bug 1580315 - Remove some nsIX509CertList glue code

Some glue code was introduced when we converted certChain in
TransportSecurityInfo from nsIX509CertList to Array.

This patch intends to remove them.

Depends on D48745

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c770a884ed23
Change certList internal representation to Array r=keeler

Comment 7

[Sean Feng [:sefeng211]]

Attachment: Bug 1580315 - Use cert array to do certList serialization

The internal representation of certList has been converted to
cert array, and this patch does it for the serialization.

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c770a884ed23

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3482abe1fc9
Use cert array to do certList serialization r=keeler

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d3482abe1fc9

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11e5baee978e
Convert certList to raw array for nsITransportSecurityInfo r=keeler,Ehsan,kershaw

Comment 12

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b064c734e317
Backed out changeset 11e5baee978e for issues related to certList. CLOSED TREE

Comment 13

[Alexandru Michis [:malexandru]]

Backed out changeset 11e5baee978e (Bug 1580315) for issues related to certList.

Backout link: https://hg.mozilla.org/integration/autoland/rev/b064c734e317213d45d79e7c7bee49f34f4aebf7

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&tochange=b064c734e317213d45d79e7c7bee49f34f4aebf7&fromchange=341d72ef4bf5fa9d5066e237c25272d46a9329c7&selectedJob=272248692

Failure logs:

• TypeError: this.secInfo is undefined at _hasCustomRoot@chrome://browser/content/browser-siteIdentity.js:681:1
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272248676&repo=autoland&lineNumber=2077
• Uncaught exception - TypeError: certificateSection.shadowRoot.querySelector(...) is null
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272248807&repo=autoland&lineNumber=3245
• ev-test.example.com should not have succeededCertChain set - false == true
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272248780&repo=autoland&lineNumber=2534
• details pane: should have the expected number of cert names - 0 == 1 - JS frame :: chrome://mochitests/content/browser/security/manager/ssl/tests/mochitest/browser/browser_certViewer.js :: checkDetailsPane :: line 391
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272248338&repo=autoland&lineNumber=795

Comment 14

[Alexandru Michis [:malexandru]]

Seems to also be causing timeouts like these:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272248309&repo=autoland&lineNumber=795

https://treeherder.mozilla.org/#/jobs?repo=autoland&tochange=b064c734e317213d45d79e7c7bee49f34f4aebf7&searchStr=os%2Cx%2C10.14%2Cdebug%2Cmochitests%2Ctest-macosx1014-64%2Fdebug-mochitest-browser-chrome-e10s-9%2Cm%28bc9%29&fromchange=341d72ef4bf5fa9d5066e237c25272d46a9329c7&selectedJob=272248309&group_state=expanded

Comment 15

[Pascal Chevrel:pascalc]

Alexandry, if I read this bug correctly, this landed in 71 nightly just before the merge and was backed out after the merge in 72 nightly. If it's not good enough for nightly to deserve a back out, shouldn't it be backed out from beta as well?

Comment 16

[Alexandru Michis [:malexandru]]

Well as far as I can see d3482abe1fc9 was the latest changeset from this bug to make it into beta, and that one didn't give us any trouble on nightly,
so I don't think we should back it out from beta.

11e5baee978e was backed out before getting into central, so that one didn't make it into beta.

Comment 17

[Phabricator Automation]

Comment on attachment 9099972 [details]
Bug 1580315 - Convert certList to raw array for nsITransportSecurityInfo

Revision D48745 was moved to bug 1592083. Setting attachment 9099972 [details] to obsolete.

Comment 18

[Sean Feng [:sefeng211]]

Created bug 1592083 for the rest of the TransportSecurityInfo changes to make this bug can be marked as resolved.