1580354 - ValueError when user-created bookmark names contain a space

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect)

Description

[Rob Lemley [:rjl]]

When a user-created bookmark (unrelated to moz-phab) contains a space character, moz-phab exits during submit with:
ValueError: too manu values to unpack

2019-09-10 17:39:37,873 DEBUG    $ hg --config extensions.rebase= bookmark -T '{active} {bookmark}\n'
2019-09-10 17:39:37,993 DEBUG    False Bug 15XXXXX
False Bug 15XXXXX
False Bug 15XXXXX
False Bug15XXXXX
False Bug15XXXXX
False DXXXXX
False DXXXXX
False DXXXXX
False bug15XXXXX
2019-09-10 17:39:37,994 ERROR    ValueError: too many values to unpack

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1580354 - Handle spaces in bookmark names. r=zalun

Only split once when reading output from hg bookmark to prevent
an error when a user-created bookmark contains a space character
in the name.

Comment 2

[Piotr Zalewa [:zalun]]

Attachment: Bug 1580354 - Testing bookmarks with space r=rjl