Fix failing writing-mode tests because of propagating WritingMode from <body>
Categories
(Core :: Layout: Block and Inline, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
References
Details
Attachments
(1 file)
After fixing bug 1102175 that propagate WritingMode (including writing-mode, direction, etc) from <body> to <html>, the following tests start to fail, and I think they need to be fixed.
- normal-flow-overconstrained-vlr-005.xht
- normal-flow-overconstrained-vrl-004.xht
(There are two copies of them: one in testing/web-platform/tests/css/css-writing-modes/, and the other in layout/reftests/w3c-css/received/css-writing-modes/.)
Both of them will behave like specifiying direction: rtl; on <html>.
|
Assignee | |
Comment 1•5 years ago
|
||
Blink starts to implement writing-mode propagation from <body> in https://chromium-review.googlesource.com/c/chromium/src/+/1852786, and the two tests are fixed there. Ideally, we should pass after the tests sync back from wpt.
|
||
Comment 2•5 years ago
|
||
Firefox 71.0a1 buildID=20191014095234 passes
http://web-platform-tests.live/css/css-writing-modes/normal-flow-overconstrained-vrl-004.xht
and
http://web-platform-tests.live/css/css-writing-modes/normal-flow-overconstrained-vlr-005.xht
|
|
Assignee | |
Comment 3•5 years ago
|
||
The two tests are importing from wpt in bug 1588038. I'll remove normal-flow-overconstrained-vrl-004.xht.ini and normal-flow-overconstrained-vlr-005.xht.ini once they reached m-c.
|
|
Assignee | |
Comment 4•5 years ago
|
||
normal-flow-overconstrained-vlr-005.xht and
normal-flow-overconstrained-vrl-004.xht have been fixed by blink team
per bug 1580385 comment 1, and Firefox passes them. We can delete the
meta files.
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/b4c675546853 Remove meta files for two writing-mode tests. r=dholbert
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Description
•