Closed Bug 158040 Opened 22 years ago Closed 22 years ago

RFE: double click to close Tab Window

Categories

(SeaMonkey :: Tabbed Browser, enhancement)

Product:
SeaMonkey
Component:
Tabbed Browser
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED WONTFIX

People

(Reporter: simford, Assigned: jag+mozilla)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

patch
1.18 KB, patch
Details | Diff | Splinter Review 
It is very convenient if we can close a Tab Window just by double click on the 
Tab. I hope this feature would be added soon.
*** Bug 158048 has been marked as a duplicate of this bug. ***
 -> Tabbed Browser.
Assignee: joki → jaggernaut
Severity: normal → enhancement
Status: UNCONFIRMED → NEW
Component: Event Handling → Tabbed Browser
Ever confirmed: true
QA Contact: rakeshmishra → sairuh
Attached patch patch — — Splinter Review 
a good and simple patch for this bug
bzbarsky, jag, asa, sicking, brendan, rginda, timeless:
Could you please give the patch 93135 the r= and sr=?

I'm marking this dependant on bug 48333, because once it gets checked in, patch
93135 will be bit-rotted.
Depends on: 48333
What tab becomes focused as a result of this patch?  The one next to the last
focused tab?  Or the one next to the tab you close?
I strongly disapprove of putting that much code in an attribute.  Why not put it
in a function instead?
bzbarsky:
the new focused tab would be the next tab of the closed tab.
it is same when you click on the close-button on the upper-right of a frame.
So.. in other words double-clicking a tab will focus it and _then_ close it. 
Whereas right click followed by "close tab" will just close the tab in question.
 That seems somewhat inconsistent.

Or does this double-click thing only work for the currently-focused tab (so
double-clicking anywhere on the tabbar closes the currently-focused tab without
changing which tab is focused)?
bzbarsky:
you are right. double-clicking a tab will focus it and _then_ close it.
you can also dblclick an un-focused tab, this patch will also close it,
then focuses the tab next to that un-focused tab(= just closed tab).

With this patch, you can close a tab just double-click on tabbar 
after you read that frame. 
how convenient!

> you can also dblclick an un-focused tab, this patch will also close it,
> then focuses the tab next to that un-focused tab(= just closed tab)

This is the behavior I have trouble buying.  why should closing one of the
_unfocused_ tabs change the focus?

Jag?  What do you think?
bzbarsky:
I mean you CAN close an unfocused frame, not you SHOULD.

I think this feature is mainly for the conveniency of closing current frame 
that you've read, not others.
Ok.. If this is supposed to act just like the [X] icon, then it should act just
like it.  In other words, close the currently-focused tab no matter where the
user double-clicked.

My point is, we've got two different tab-closing behaviors already.  This patch
introduces a third one, one that is particularly bizarre, imo.  I'd like to see
some input from UI people (module owners, UE, whatever) on that.
ok, so you asked for my comment, yuck.

supposing we ever get tab rearrangement via drag and drop, this will be a nice
disaster.

how tab reordering might work:
you click and drag a tab to a new place.

surpisingly enough, this is how you rearrange files on the desktop.

i can't think of an os where double clicking a file deletes it.

and please don't tell me that a tab doesn't have any original information which
you can always restore from some other location.

in short, i'm opposed to this.

oh right, what did my dragging comment have to do with anything? some people
will click once to activate and then click once to drag, and poof instead of
dragging, they've thrown their poor tab to the shredder.  you can already close
a tab in two clicks (many ways in fact: [click tab, click x] [right click tab,
click close tab]).  Double clicking is supposed to be assigned to *default*
actions. and you can't argue that the default action for using a tab is
destroying it.
Thinking about this, if I were to hook double-clicking up to anything, it would
be to blow the tab up into its own window. Since we already have right-click ->
close, a close button, and File -> Close Tab, I suggest WONTFIX.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → WONTFIX
I think we all agree. verified.
Status: RESOLVED → VERIFIED
I disagree.
I am currently switching from Crazy Browser to Phoenix, the reasons are
irrelevant. The main reason why I hesitated was that Phoenix (like Mozilla) did
not support closing a tab with double click. Crazy Browser does.

I tell you: it's extremely convinient and I was at no time confused by it. Yes,
it focuses unfocused tabs shortly before closing them, but this does not disturb.
You ask for GUI designers? Whoever has put the X button so far away from the tab
bars should have done so.
You fear that some users might accidently double click a tab bar when they want
to drag it? Well, Crazy Browser supports tab d&d as well, and again, it is no
problem. At least to me.
Still fear those users? Implement double click and make it an option in the
preferences which is disabled by default.

Crazy Browser does also have an X button and a context menu. Even the context
menu is more convinient because the entry you most likeley want when opening the
context menu is right on the top - the close entry. With Phoenix, it's the
second to last - to slow for me! I feel very handicapped without the double
click feature. The only shortcut that comes close in terms of speed is Ctrl+F4 -
but it's a keyboard shortcut, and though I'm a keyboard fan, there are times
where I only use the mouse.

See & Feel it: http://www.crazybrowser.com
Crazy Browser uses IE as it's engine, uses tabs, has a popup filter and some
other goodies, too. If you HAVE to use IE, Crazy Browser is your choice.
I am about to file an enh for double-clicking tabs

in my experience double-click would be useful if it reloaded the tab window.
Perhaps double-click action should be assignable?
Depends on: 187586
Double-clicking the tab should do nothing.

EXCEPT maybe open the tab in a new window.
What do you expect when you doubleclick something ? It opens. If CrazyBrowser
closes the tab when you doubleclick it, well, too bad. Bad design IMO.

I'm not suggesting that mozilla should support this, I'm only saying that
opening the tab in a new window is the only logical result of a double-click.
Those who want to have tabs closed by double click and several other nice tools
for tabs can download the "Tabbrower Extensions":
http://white.sakura.ne.jp/~piro/xul/_tabextensions.html.en
German version: http://mozilla.daicogra.de/
I hope that it works well enough with Phoenix, too.

BTW: I did not know that tabs close by pressing the middle mouse button, which
is already quite nice.
Though I don't get why you do not want to allow every user to break the
usability on their own.
No longer depends on: 48333
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: