Closed Bug 1580449 Opened 6 years ago Closed 6 years ago

Update shell scripts with shellcheck 0.7.0 guidelines

Categories

(Release Engineering :: Release Automation, defect)

Product:
Release Engineering
Component:
Release Automation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox71 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: sfraser, Assigned: sfraser)

Details

Attachments

(1 file)

Bug 1580449 Update '! -z' to '-n' for shellcheck guidelines r=mtabara
47 bytes, text/x-phabricator-request
Details | Review

We'll update shellcheck soon, and these errors will appear when we do. Fix them now.

/Users/sfraser/hg.m.o/mozilla-central/taskcluster/docker/funsize-update-generator/runme.sh
  56:6  error  Use -n instead of ! -z.  2236 (shellcheck)

/Users/sfraser/hg.m.o/mozilla-central/taskcluster/docker/periodic-updates/runme.sh
  19:6  error  Use -n instead of ! -z.  2236 (shellcheck)
  25:6  error  Use -n instead of ! -z.  2236 (shellcheck)
  30:6  error  Use -n instead of ! -z.  2236 (shellcheck)
  35:6  error  Use -n instead of ! -z.  2236 (shellcheck)
  40:6  error  Use -n instead of ! -z.  2236 (shellcheck)
  45:6  error  Use -n instead of ! -z.  2236 (shellcheck)

✖ 7 problems (7 errors, 0 warnings)
Assignee: nobody → sfraser
Pushed by sfraser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/001f3b7fc552 Update '! -z' to '-n' for shellcheck guidelines r=mtabara

https://hg.mozilla.org/mozilla-central/rev/001f3b7fc552

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: