Closed Bug 1580455 Opened 6 years ago Closed 6 years ago

Use proper keys in adjustCertInformation, make section names localizable

Categories

(Firefox :: Security, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: johannh, Assigned: carolina.jimenez.g)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

Attachments

(1 file)

In certviewer.js, what we do right now is we hardcode some "human-readable" version of the the key for an entry: https://searchfox.org/mozilla-central/rev/588814f2edddf0e132d77d326ddae50911e8bad1/toolkit/components/certviewer/content/certviewer.js#145

And then later when we need to transform it to e.g. a className or an l10n key we call normalizeToKebapCase to transform it into e.g. subject-alt-names. Since we're never actually displaying that text to users there's no point in not just using the kebap-cased version from the start in adjustCertInformation.

Depends on: 1580500
Assignee: nobody → carolina.jimenez.g
Depends on: 1571710
Summary: Use proper keys in adjustCertInformation → Use proper keys in adjustCertInformation, make section names localizable
No longer depends on: 1571710
No longer depends on: 1580500
Keywords: checkin-needed

Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c407e5da6487
Uses normalizeToKebabCase in adjustCertInformation for the result labels.r=johannh,fluent-reviewers,flod

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Regressions: 1584548
Regressions: 1661163
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: