Closed Bug 1580485 Opened 4 months ago Closed 4 months ago

Search worker should be created on demand

Categories

(DevTools :: Debugger, task, P3)

71 Branch
task

Tracking

(firefox71 fixed)

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: sorin.davidoi, Assigned: sorin.davidoi)

Details

Attachments

(1 file)

Steps to reproduce:

Opened debugger.

Actual results:

The search worker was started as part of the bootstrap.

Expected results:

Given that probably a small minority of users that open the debugger use the search functionality, the worker should not be created up-front in order to reduce memory usage and the overhead of starting a thread.

Took care to only call .task once. Maybe it would be nice to move this functionality inside WorkerDispatcher?

Assignee: nobody → sorin.davidoi
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Type: enhancement → task
Priority: -- → P3
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a227ecdcca5
Start search worker on lazily. r=jlast

Backed out changeset 0a227ecdcca5 (bug 1580485) for debugger failure

Backout: https://hg.mozilla.org/integration/autoland/rev/1775bf2141f50397049fb4517e37f9ceb930f596

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=0a227ecdcca5ddd24c4faae01cd6632b90bf5ef3

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=266369186&repo=autoland&lineNumber=97

[task 2019-09-12T17:55:40.489Z] Error -------------------------------------------------------------------------------- src/workers/search/index.js:34:31
[task 2019-09-12T17:55:40.489Z]
[task 2019-09-12T17:55:40.489Z] Missing type annotation for rest parameter args.
[task 2019-09-12T17:55:40.489Z]
[task 2019-09-12T17:55:40.489Z] 34| export const getMatches = (...args) => {
[task 2019-09-12T17:55:40.489Z] ^^^^
[task 2019-09-12T17:55:40.489Z]
[task 2019-09-12T17:55:40.489Z]
[task 2019-09-12T17:55:40.489Z] Error -------------------------------------------------------------------------------- src/workers/search/index.js:38:38
[task 2019-09-12T17:55:40.489Z]
[task 2019-09-12T17:55:40.489Z] Missing type annotation for rest parameter args.
[task 2019-09-12T17:55:40.489Z]
[task 2019-09-12T17:55:40.489Z] 38| export const findSourceMatches = (...args) => {
[task 2019-09-12T17:55:40.489Z] ^^^^
[task 2019-09-12T17:55:40.489Z]
[task 2019-09-12T17:55:40.489Z]
[task 2019-09-12T17:55:40.489Z]
[task 2019-09-12T17:55:40.489Z] Found 3 errors
[task 2019-09-12T17:55:40.489Z]
[task 2019-09-12T17:55:58.906Z] TEST-UNEXPECTED-FAIL flow | Missing type annotation for rest parameter args.
[task 2019-09-12T17:55:58.906Z] TEST-UNEXPECTED-FAIL flow | Missing type annotation for rest parameter args.
[task 2019-09-12T17:55:58.906Z] TEST-UNEXPECTED-FAIL flow | Missing type annotation for rest parameter args.
[task 2019-09-12T17:55:58.907Z] TEST START | Eslint
[task 2019-09-12T17:56:50.851Z] yarn run v1.9.4
[task 2019-09-12T17:56:50.851Z] $ eslint .js "src/**/.js" "packages//src/**/.js" --fix
[task 2019-09-12T17:56:50.851Z]

Flags: needinfo?(sorin.davidoi)

Should be fixed now.

Flags: needinfo?(sorin.davidoi)
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2a9d91a5f539
Start search worker on lazily. r=jlast
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in before you can comment on or make changes to this bug.