1580488 - Hide media.videocontrols.picture-in-picture.enabled from the about:config

Status: RESOLVED WORKSFORME

(Toolkit :: Picture-in-Picture, defect, P4)

Description

[Mike Conley (:mconley) (:⚙️)]

Reproduce: always

Steps To Reproduce:

1. set media.videocontrols.picture-in-picture.enabled to false
2. Open any video

Actual Results:
Picture-in-Picture toggle icon display

Expected Results:
Picture-in-Picture toggle icon should not display

Comment 1

[Mike Conley (:mconley) (:⚙️)]

This is because the pref to control the toggle is media.videocontrols.picture-in-picture.video-toggle.enabled. We should probably also hide the toggle if media.videocontrols.picture-in-picture.enabled is set to false.

Comment 2

[Charlie Hayes]

I have all the picture-in-picture stuff disabled and it still shows. It's interfering with video elements and websites that have their own UIs. I didn't even realize it was a firefox feature until I spent an hour trying to use greasemonkey to get rid of it.

I'll attach a screenshot as evidence.

Firefox 69.0.1 (64-bit) on MacOS 10.13.6 (17G6030)

Comment 3

[Charlie Hayes]

Attachment: flyout.png

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Are you still seeing this in Firefox 70, Charlie?

Comment 5

[Adam Stevenson [:adamopenweb]]

I assume this issue has been resolved at this point. Please comment or reopen if it's still reproducing. Thanks!

Comment 6

[Daniel Bodea [:danibodea]]

As described in comment 0, this issue still occurs in the latest Nightly v100.0a1 from 2022-04-04 on all OSes.
It appears as I can't reopen it. Can you reopen it or should I log a new report?

Comment 7

[Ania]

Niklas, is there anything elsemedia.videocontrols.picture-in-picture.enabled is used for? Let's get rid of this pref if not to avoid future confusion, perhaps?

Comment 8

[Niklas Baumgardner [:niklas]]

It looks like we do use media.videocontrols.picture-in-picture.enabled in a few places so I don't think we should get rid of it. But this bug was never fixed so I will reopen it and create a patch.

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Bodea Daniel [:danibodea] from comment #6)

As described in comment 0, this issue still occurs in the latest Nightly v100.0a1 from 2022-04-04 on all OSes.
It appears as I can't reopen it. Can you reopen it or should I log a new report?

I also can't reopen the bug. That's the first time I've seen that. Yes, can you log a new report?

Comment 10

[Niklas Baumgardner [:niklas]]

New bug has been filed here https://bugzilla.mozilla.org/show_bug.cgi?id=1763160