1580495 - Wrong function parameter name in InternalHeaders::CORSHeaders

Status: RESOLVED FIXED

(Core :: DOM: Networking, enhancement, P3)

Description

[Kershaw Chang [:kershaw]]

The parameter name mCredentialsMode should be changed to aCredentialsMode.

Comment 1

[wesgur]

I would like to work on this bug if no one is working on it.

Comment 2

[Shrey Gupta]

Hi, I would like to contribute to this bug. It is my first bug fix so could you please guide me and tell me how to proceed.
Thanks

Comment 3

[Shrey Gupta]

I changed the parameter name but when I commit it shows "nothing changed". Kindly help

Comment 4

[Shrey Gupta]

Moz-phab is submitting all commits made while I want to submit only the last one.How to do that?

Comment 5

[Shrey Gupta]

Attachment: Bug 1580495 - Changed function parameter mCredentialsMode to aCredentialsMode in InternalHeaders::CORSHeaders. r=baku

Depends on D60366

Comment 6

[Shrey Gupta]

Attachment: Bug 1580495 - Changed function parameter mCredentialsMode to aCredentialsMode in InternalHeaders::CORSHeaders. r=baku

Depends on D60368

Comment 7

[Shrey Gupta]

Hello,
D60369 is the actual bug fix.
The other one was created by accident.
As it is my first time fixing bugs in open-source. Kindly apologise for the inconvenience
Thanks

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:shrey2809, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 6 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6aeee37c70c2
Changed function parameter mCredentialsMode to aCredentialsMode in InternalHeaders::CORSHeaders. r=baku

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6aeee37c70c2