1580524 - Free conduits when transceiver is stopped

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement, P2)

Description

[Dan Minor [:dminor]]

Once a transceiver is stopped it will never be restarted, so we should be able to free up the underlying webrtc.org objects at that point. This should help with stopped transceiver memory usage.

Comment 1

[Dan Minor [:dminor]]

Attachment: Bug 1580524 - Free conduits when transceiver is stopped; r=bwc!

Freeing the conduits when the transceiver is stopped releases all of the
associated webrtc.org objects which results in substantial memory savings.

On my system, with an opt+debug build and 200 stopped transceivers, I see
373.17 MB of memory use in the content process without this patch, and
158.93 MB of memory use with this patch applied.

Going further and calling Shutdown_m as part of Stop() reduces the memory
use to 157.98 MB, which seems like a marginal improvement at the cost of
a much larger risk of introducing bugs.

Comment 2

[Dan Minor [:dminor]]

Try job here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f038bfb49d2a2b7e20b152a21bc73358ef41072

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/598d441e4eba
Free conduits when transceiver is stopped; r=bwc

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/598d441e4eba