1580601 - Fix usage of nsIDocShellTreeItem in nsDocShell::InternalLoad

Status: NEW

(Core :: DOM: Navigation, defect, P2)

Description

[Kannan Vijayan [:djvj]]

Two uses, the first is more significant.

https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/docshell/base/nsDocShell.cpp#9347

Here, InternalLoad gets the parent docshell (any type), and if it exists, gets the document from it and calls TryCancelFrameLoaderInitialization() on it.

This has to be checked for OOP parent, an if so forwarded to the appropriate process.

https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/docshell/base/nsDocShell.cpp#9529

This usage is a much simpler fix. It occurs within #ifdef DEBUG code, retrieves the parent and asserts that it is null. Just needs to be changed to use BrowsingContext tree instead to check existence of a (same-type) parent.

Comment 1

[Chris Peterson [:cpeterson]]

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Comment 2

[Nika Layzell [:nika] (ni? for response)]

This is only relevant in the in-process case, as we will never be in this situation when across process boundaries. This code is only relevant due to timing of frame loader initialization.