1580636 - Inline Preview: Set left style before rendering

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[David Walsh :davidwalsh]

When an inline preview doesn't yet exist, we inject the DOM element, then calculate the left property and move the DOM element.

We should get a perf boost by first calculating the left property, setting the left property, then injecting the DOM node.

Comment 1

[David Walsh :davidwalsh]

Attachment: Bug 1580636 - Set inline preview left before injection r=jlast

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7e276985276
Set inline preview left before injection r=jlast

Comment 3

[Razvan Maries]

Backed out for ES Lint failure.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&searchStr=linting%2Copt%2Cjavascript%2Cchecks%2Csource-test-mozlint-eslint%2Cjs%28es%29&revision=c7e27698527679d136485cd515eb08ae13bad421

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=266319150&repo=autoland&lineNumber=244

Backout: https://hg.mozilla.org/integration/autoland/rev/a00ff5a8af1d827fa69fa236f223063b71b60cdf

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f86b0af282c4
Set inline preview left before injection r=jlast

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/f86b0af282c4

Comment 6

[:Harald Kirschner :digitarald]

[Tracking Requested - why for this release]: Performance regression if we decide to switch on Inline Preview for release.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Did this improve the perf problem? Do you want to request uplift?

Comment 8

[David Walsh :davidwalsh]

Hello Liz! This didn't have the impact we'd hoped so no need to uplift, imo.