1580646 - "Launch Application" window's "Cancel" button should be right of the "Open link" button on Windows

Status: VERIFIED FIXED

(Firefox :: File Handling, defect, P1)

Description

[Chris Peterson [:cpeterson]]

Attachment: Launch_Application_screenshot.jpg

Firefox's "Launch Application" window's "Cancel" button is on the left of the "Open link" button, but Windows' UI convention is that "Cancel" buttons should be on the right. (macOS's UI convention is for "Cancel" buttons to be on the left.) See the attached screenshot comparing Firefox's "Launch Application" window and Windows' own file picker dialog.

https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/toolkit/mozapps/handling/content/dialog.xul#47-50

Comment 1

[:Gijs (he/him)]

Some combination of bug 1552627 and bug 1544916 broke this, I think. I don't have a Windows machine handy today (working away from home). I'll try and get a patch up tonight or tomorrow. Chris, I don't suppose you know off-hand if esr68 is affected?

Comment 2

[Marco Bonardo [:mak]]

I can reproduce the problem on Firefox 69 and ESR 68.1
I'll run mozregression to check the regrange.

Comment 3

[Marco Bonardo [:mak]]

I can also reproduce this on Firefox 66 and Firefox 59... didn't go further. Are we sure this wasn't just broken from the beginning?
From how the dialog is defined it looks like we just forgot to ifdef the order of buttons.

Comment 4

[:Gijs (he/him)]

(In reply to Marco Bonardo [::mak] from comment #3)

I can also reproduce this on Firefox 66 and Firefox 59... didn't go further. Are we sure this wasn't just broken from the beginning?
From how the dialog is defined it looks like we just forgot to ifdef the order of buttons.

Yeah, I think I assumed that it used to work in the old dialog XBL binding and that reordered the buttons, but it looks like it never did. Oops.

Comment 5

[:Gijs (he/him)]

Attachment: Bug 1580646 - move default button to the right place on Windows, r?mak

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32cab40a14b5
move default button to the right place on Windows, r=mak

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/32cab40a14b5

Comment 8

[:Gijs (he/him)]

Comment on attachment 9093915 [details]
Bug 1580646 - move default button to the right place on Windows, r?mak

Beta/Release Uplift Approval Request

• User impact if declined: Buttons wrong way around
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just ifdef'ing some buttons so they're the other way around on Windows
• String changes made/needed: Nope

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9093915 [details]
Bug 1580646 - move default button to the right place on Windows, r?mak

Low risk patch, uplift approved for 70 beta 9, thanks.

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/077185f22a94

Comment 11

[Timea Zsoldos [:tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 71.0a1 (2019.09.11) on Win 10 x64.
I can confirm this issue is fixed, I verified using Firefox 70.0b9 and on latest nightly 71.0a1 on Win 10 x64.

Comment 13

[Gian-Carlo Pascutto [:gcp]]

Are we sure this wasn't just broken from the beginning?

It was broken by bug 510516, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1304666#c0