Closed Bug 1580697 Opened 11 months ago Closed 7 months ago

Enable compiling servo/webrender code in SeaMonkey 2.53 with later rust versions.

Categories

(SeaMonkey :: Build Config, defect)

SeaMonkey 2.53 Branch
defect
Not set
normal

Tracking

(seamonkey2.49esr unaffected, seamonkey2.53 fixed)

RESOLVED FIXED
seamonkey2.53
Tracking Status
seamonkey2.49esr --- unaffected
seamonkey2.53 --- fixed

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

Details

Attachments

(3 files)

Fixes needed in servo/webrender code used for SeaMonkey 2.53

[Approval Request Comment]
Regression caused by (bug #): update to rustc 1.37+
User impact if declined: users cannot compile locally unless they disable fatal warnings in relevant lib.rs
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Not tried against esr-60 code yet

Attachment #9092273 - Flags: review?(frgrahl)
Attachment #9092273 - Flags: approval-comm-release?
Blocks: 1584803
Comment on attachment 9092273 [details] [diff] [review]
Needed changed for compiling with rust 1.37

LGTM.

2.53 for now. 2.57 will need other changes. Open a new bug later?
Attachment #9092273 - Flags: review?(frgrahl)
Attachment #9092273 - Flags: review+
Attachment #9092273 - Flags: approval-comm-release?
Attachment #9092273 - Flags: approval-comm-release+
Version: Trunk → SeaMonkey 2.53 Branch
Summary: Fix servo/webrender code in SM2.53 for rustc 1.37 → Enable compiling servo/webrender code in SeaMonkey 2.53 with later rust versions.
Attachment #9092273 - Attachment description: Mainly dyn changes → Needed changed for compiling with rust 1.37

Make rust 1.33 happy

Attachment #9114395 - Flags: review?(iann_bugzilla)
Attachment #9114395 - Flags: approval-comm-release?

Make rust 1.35 happy

Attachment #9114396 - Flags: review?(iann_bugzilla)
Attachment #9114396 - Flags: approval-comm-release?

(In reply to Frank-Rainer Grahl (:frg) from comment #2)

Comment on attachment 9092273 [details] [diff] [review]
Needed changed for compiling with rust 1.37

LGTM.

2.53 for now. 2.57 will need other changes. Open a new bug later?

Yes

Comment on attachment 9114395 [details]
Needed changed for compiling with rust 1.33

[Triage Comment]
r/a=me
Attachment #9114395 - Flags: review?(iann_bugzilla)
Attachment #9114395 - Flags: review+
Attachment #9114395 - Flags: approval-comm-release?
Attachment #9114395 - Flags: approval-comm-release+
Comment on attachment 9114396 [details]
Needed changed for compiling with rust 1.35

[Triage Comment]
r/a=me
Attachment #9114396 - Flags: review?(iann_bugzilla)
Attachment #9114396 - Flags: review+
Attachment #9114396 - Flags: approval-comm-release?
Attachment #9114396 - Flags: approval-comm-release+
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.53
You need to log in before you can comment on or make changes to this bug.