1580697 - Enable compiling servo/webrender code in SeaMonkey 2.53 with later rust versions.

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Ian Neal]

Fixes needed in servo/webrender code used for SeaMonkey 2.53

Comment 1

[Ian Neal]

Attachment: Needed changed for compiling with rust 1.37

[Approval Request Comment]
Regression caused by (bug #): update to rustc 1.37+
User impact if declined: users cannot compile locally unless they disable fatal warnings in relevant lib.rs
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Not tried against esr-60 code yet

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9092273 [details] [diff] [review]
Needed changed for compiling with rust 1.37

LGTM.

2.53 for now. 2.57 will need other changes. Open a new bug later?

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: Needed changed for compiling with rust 1.33

Make rust 1.33 happy

Comment 4

[Frank-Rainer Grahl (:frg)]

Attachment: Needed changed for compiling with rust 1.35

Make rust 1.35 happy

Comment 5

[Ian Neal]

(In reply to Frank-Rainer Grahl (:frg) from comment #2)

Comment on attachment 9092273 [details] [diff] [review]
Needed changed for compiling with rust 1.37

LGTM.

2.53 for now. 2.57 will need other changes. Open a new bug later?

Yes

Comment 6

[Ian Neal]

Comment on attachment 9114395 [details]
Needed changed for compiling with rust 1.33

[Triage Comment]
r/a=me

Comment 7

[Ian Neal]

Comment on attachment 9114396 [details]
Needed changed for compiling with rust 1.35

[Triage Comment]
r/a=me

Comment 8

[Frank-Rainer Grahl (:frg)]

Fixed in 2.53 beta 1 gitlab branch:
https://gitlab.com/seamonkey-project/seamonkey-2.53-mozilla/tree/2_53_beta_01