1580888 - Allow black marking during gray marking

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement, P3)

Description

[Steve Fink [:sfink] [:s:]]

For incremental weakmap marking, I need to be able to mix gray and black marking a little, due to weakmap CCW keys being preserved by their wrapped delegates. (If the delegate is black, then the key needs to be black, even if we were marking gray at the time we encountered the key.)

Sadly, it is very difficult to implement this without regressing memory usage. My current push doesn't look too bad, though: https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=03818d9310a331b55ba396c2bb90bcb1673d7a5f&newProject=try&newRevision=b1c9ae391f6b226bf04abafb98c1f44bda2f923b&framework=4

The main result there is a 0.8% regression in awsy-base. I'm doing some more retriggers of the baseline to get a clearer picture (I didn't have enough Windows runs.)

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1580888 - Split mark stack into main stack and spare stack. r=jonco

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1580888 - Stop holding onto mark stack memory between GCs r=jonco

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4a752751ba0
Stop holding onto mark stack memory between GCs r=jonco
https://hg.mozilla.org/integration/autoland/rev/1589fa5ffccb
Split mark stack into main stack and spare stack. r=jonco

Comment 5

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1580888) for build bustage. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=273719354&repo=autoland&lineNumber=5234

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=1589fa5ffccb2b03fa15baba78db3901808c9105

Backout:
https://hg.mozilla.org/integration/autoland/rev/a3f97f3a1573027a530b1371e8e94fbd52193789

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/730504cec75c
Stop holding onto mark stack memory between GCs r=jonco

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b9a68f46ef5
Split mark stack into main stack and spare stack. r=jonco

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/304f062595a5
Backed out changeset 0b9a68f46ef5 for assertion failures at ProtectedData.cpp on a CLOSED TREE

Comment 9

[Andreea Pavel [:apavel]]

Backed out for assertion failures at ProtectedData.cpp

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=0b9a68f46ef5444f23416997f78e8ce9195dfcb2&selectedJob=273742769

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=273742769&repo=autoland&lineNumber=1660

Backout: https://hg.mozilla.org/integration/autoland/rev/304f062595a5d8adf3f7f5932b48f305213e64dc

There were also SM bustages that crashed: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=0b9a68f46ef5444f23416997f78e8ce9195dfcb2&selectedJob=273735963

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=273735963&repo=autoland&lineNumber=8100

Comment 10

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/730504cec75c

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8fcd8060719e
Split mark stack into main stack and spare stack. r=jonco

Comment 12

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/8fcd8060719e

Comment 13

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/730504cec75c