Closed Bug 1580909 Opened 1 year ago Closed 1 year ago

Javascript error on New Bug form causing the default setting for showing advanced fields to be ignored

Categories

(bugzilla.mozilla.org :: Bug Creation/Editing, defect)

Production
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: mhoye, Assigned: glob)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

46 bytes, text/x-github-pull-request
Details | Review

I'm finding myself clicking "show advanced fields" a lot when I'm entering bugs.

If possible, could I have a toggle somewhere in my account that causes showing the advanced fields to be the default behavior on bug creation?

Thanks.

There's a javascript error on page load, which means the code which reads the "show advanced fields by default" cookie is never hit

TypeError: aSelect.length is undefined util.js:189:3
    bz_createOptionInSelect https://bugzilla.mozilla.org/static/v20190906.1/js/util.js:189
    browserCanHideOptions https://bugzilla.mozilla.org/static/v20190906.1/js/field.js:691
    initHidingOptionsForIE https://bugzilla.mozilla.org/static/v20190906.1/js/field.js:656
    <anonymous> https://bugzilla.mozilla.org/enter_bug.cgi?product=Firefox:1281
Type: enhancement → defect
Component: User Interface: Modal → Bug Creation/Editing
Keywords: regression
Summary: Feature request: Default to Show-All. → Javascript error on New Bug form causing the default setting for showing advanced fields to be ignored
Version: Staging → Production

Bug 1522341 added the bug_type field as FIELD_TYPE_SINGLE_SELECT.

bug/field.html.tmpl expects all SINGLE_SELECT fields to be implemented as <select> in html, and calls initHidingOptionsForIE() on them, which explodes when it doesn't see a select object.

We should probably nuke all the code for hiding options in IE (exists for IE7 and earlier).

Regressed by: 1522341
Assignee: nobody → glob
Attached file GitHub Pull Request β€”

Merged to master.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.