1580936 - Inactive CSS: Final visual polish, Part Two (_final_final.jpg)

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, enhancement, P2)

Description

[Victoria Wang [:victoria]]

Attachment: Screen Shot 2019-09-12 at 12.49.19 PM.png

(Oof, sorry to have to file yet another bug on this!)

I thought the padding issues were fixed as of this bug, but I'm realizing the specs I gave didn't translate into the exact results I was looking for.

Both doorhanger types have 2px too much top padding.

Also, it seems there is a mysterious extra 4px bottom padding that only appears when the doorhanger flips down.

I've attached an image that shows the issues. Please let me know if you have questions!

Comment 1

[Victoria Wang [:victoria]]

Attachment: image.png

Should look like this after the changes are made

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1580936 - [Inactive CSS] Final visual polish, Part Two r?jdescottes!

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Fixed

@Victoria Here is the tooltip with your changes.

Comment 4

[Victoria Wang [:victoria]]

This is perfect! Thank you Mike!

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: tooltip.png

Here's Victorias requested tooltip dimensions from the other bug.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41e973809557
[Inactive CSS] Final visual polish, Part Two r=jdescottes

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/41e973809557