Closed Bug 1580936 Opened 2 months ago Closed 2 months ago

Inactive CSS: Final visual polish, Part Two (_final_final.jpg)

Categories

(DevTools :: Inspector: Rules, enhancement, P2)

enhancement

Tracking

(firefox71 fixed)

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: victoria, Assigned: miker)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

(Oof, sorry to have to file yet another bug on this!)

I thought the padding issues were fixed as of this bug, but I'm realizing the specs I gave didn't translate into the exact results I was looking for.

Both doorhanger types have 2px too much top padding.

Also, it seems there is a mysterious extra 4px bottom padding that only appears when the doorhanger flips down.

I've attached an image that shows the issues. Please let me know if you have questions!

Blocks: 1540753
Attached image image.png

Should look like this after the changes are made

Priority: -- → P2
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Attached image Fixed

@Victoria Here is the tooltip with your changes.

This is perfect! Thank you Mike!

Attached image tooltip.png

Here's Victorias requested tooltip dimensions from the other bug.

Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/41e973809557
[Inactive CSS] Final visual polish, Part Two r=jdescottes
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Regressions: 1590408
No longer regressions: 1590408
You need to log in before you can comment on or make changes to this bug.