1580962 - For extensions that can't be removed, show message and link to SUMO

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, enhancement, P1)

Description

[Jorge Villalobos [:jorgev] (he/him)]

Sideloaded add-ons can't be completely removed at present (bug 640775). As a mitigation, we want to link users to relevant documentation on how to remove those add-ons.

So, in place of the missing Remove option in the meatball menu, there should be a menu item labelled "Can't be removed. Learn More.", that opens https://support.mozilla.org/kb/cannot-remove-add-on-extension-or-theme in a new tab.

Comment 1

[Jorge Villalobos [:jorgev] (he/him)]

ni Jeff for content.

Comment 2

[Jeff Pfaller]

My reco would be "Can't Be Removed" as a greyed out item, with the link saying "Why?"

Will the menu expand horizontally to account for this longer string?

There is also a risk that if the target of the Why link moves, we'll have a broken experience.

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

Will the menu expand horizontally to account for this longer string?

I think it should. Mark, do you have any concerns about the length here, particularly for localized versions?

There is also a risk that if the target of the Why link moves, we'll have a broken experience.

We expect the menu item to be temporary (a couple/few releases), so the URL changing shouldn't be a big concern.

Comment 4

[Mark Striemer [:mstriemer]]

Attachment: English.png

The panel will expand to fit the string.

We'll want a version of this URL that matches the format we use for other support URLs, private browsing end up as https://support.mozilla.org/1/firefox/71.0a1/Darwin/en-US/extensions-pb (I need that "extensions-pb" part).

I checked German as well, and it's a little long but probably better than the frustration of not being able to remove and not having any indication about why.

Jeff, is the "Why?" string okay to localise on its own like the "Learn More" strings we have elsewhere? Looks like we only use this string in one other place.

Comment 5

[Mark Striemer [:mstriemer]]

Attachment: German.png

Just the one string in German (from Google Translate) to test, I can't imagine the other strings are nearly as long, but this doesn't seem too terrible.

Comment 6

[Jeff Pfaller]

Looks good!

Comment 7

[Jorge Villalobos [:jorgev] (he/him)]

We'll want a version of this URL that matches the format we use for other support URLs, private browsing end up as https://support.mozilla.org/1/firefox/71.0a1/Darwin/en-US/extensions-pb (I need that "extensions-pb" part).

Caitlin, do you know how to get the SUMO article URL in that format?

Comment 8

[Caitlin Neiman [:caitmuenster]]

Joni, can you help us out with this?

Comment 9

[Joni Chan]

Sure thing, here's the link: https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/cant-remove-addon

It will redirect to https://support.mozilla.org/en-US/kb/cannot-remove-add-on-extension-or-theme

Comment 10

[Mark Striemer [:mstriemer]]

Attachment: Bug 1580962 - Show a SUMO link when an add-on can't be removed r?rpl

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10c62a0c06f0
Show a SUMO link when an add-on can't be removed r=rpl,fluent-reviewers,flod

Comment 12

[Raul Gurzau (:RaulG)]

Backed out changeset 10c62a0c06f0 (bug 1580962) for remove button related failures at browser_policy_extensions.js on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/autoland/rev/03dfec473c4243a6a8ab637f48c4edd38a6f0ca2

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=270517503&resultStatus=testfailed%2Cbusted%2Cexception%2Csuperseded%2Cretry%2Cusercancel&searchStr=mochitest&revision=efe4efedafd64d274516990740e76a26bf0a7b04

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=270517503&repo=autoland&lineNumber=2320

Log snippet:
[task 2019-10-09T16:59:16.159Z] 16:59:16 INFO - TEST-START | browser/components/enterprisepolicies/tests/browser/browser_policy_extensions.js
[task 2019-10-09T16:59:17.083Z] 16:59:17 INFO - TEST-INFO | started process screentopng
[task 2019-10-09T16:59:17.514Z] 16:59:17 INFO - TEST-INFO | screentopng: exit 0
[task 2019-10-09T16:59:17.515Z] 16:59:17 INFO - Buffered messages logged at 16:59:16
[task 2019-10-09T16:59:17.515Z] 16:59:17 INFO - Entering test bound policies_headjs_startWithCleanSlate
[task 2019-10-09T16:59:17.515Z] 16:59:17 INFO - TEST-PASS | browser/components/enterprisepolicies/tests/browser/browser_policy_extensions.js | Engine is inactive at the start of the test -
[task 2019-10-09T16:59:17.516Z] 16:59:17 INFO - Leaving test bound policies_headjs_startWithCleanSlate
[task 2019-10-09T16:59:17.516Z] 16:59:17 INFO - Entering test bound test_addon_install
[task 2019-10-09T16:59:17.517Z] 16:59:17 INFO - TEST-PASS | browser/components/enterprisepolicies/tests/browser/browser_policy_extensions.js | Sanity check the temporary file doesn't exist. - true == true -
[task 2019-10-09T16:59:17.517Z] 16:59:17 INFO - TEST-PASS | browser/components/enterprisepolicies/tests/browser/browser_policy_extensions.js | Addon not installed. -
[task 2019-10-09T16:59:17.517Z] 16:59:17 INFO - TEST-PASS | browser/components/enterprisepolicies/tests/browser/browser_policy_extensions.js | Addon version is correct -
[task 2019-10-09T16:59:17.518Z] 16:59:17 INFO - TEST-PASS | browser/components/enterprisepolicies/tests/browser/browser_policy_extensions.js | Got the expected addon.installTelemetryInfo - {"source":"enterprise-policy"} deepEqual {"source":"enterprise-policy"} -
[task 2019-10-09T16:59:17.518Z] 16:59:17 INFO - Leaving test bound test_addon_install
[task 2019-10-09T16:59:17.518Z] 16:59:17 INFO - Entering test bound test_addon_locked
[task 2019-10-09T16:59:17.519Z] 16:59:17 INFO - Console message: [JavaScript Error: "Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome://global/content/elements/menupopup.js" line: 52}]
[task 2019-10-09T16:59:17.519Z] 16:59:17 INFO - Buffered messages finished
[task 2019-10-09T16:59:17.521Z] 16:59:17 INFO - TEST-UNEXPECTED-FAIL | browser/components/enterprisepolicies/tests/browser/browser_policy_extensions.js | Remove button should be hidden -
[task 2019-10-09T16:59:17.522Z] 16:59:17 INFO - Stack trace:
[task 2019-10-09T16:59:17.522Z] 16:59:17 INFO - chrome://mochikit/content/browser-test.js:test_ok:1575
[task 2019-10-09T16:59:17.522Z] 16:59:17 INFO - chrome://mochitests/content/browser/browser/components/enterprisepolicies/tests/browser/browser_policy_extensions.js:isExtensionLocked:19
[task 2019-10-09T16:59:17.522Z] 16:59:17 INFO - chrome://mochitests/content/browser/browser/components/enterprisepolicies/tests/browser/browser_policy_extensions.js:test_addon_locked:49
[task 2019-10-09T16:59:17.523Z] 16:59:17 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1345
[task 2019-10-09T16:59:17.523Z] 16:59:17 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1380
[task 2019-10-09T16:59:17.523Z] 16:59:17 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1208
[task 2019-10-09T16:59:17.523Z] 16:59:17 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:805
[task 2019-10-09T16:59:17.523Z] 16:59:17 INFO - TEST-PASS | browser/components/enterprisepolicies/tests/browser/browser_policy_extensions.js | Disable button should be hidden -
[task 2019-10-09T16:59:17.523Z] 16:59:17 INFO - Leaving test bound test_addon_locked

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69c42f69941b
Show a SUMO link when an add-on can't be removed r=rpl,fluent-reviewers,flod

Comment 14

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/69c42f69941b

Comment 15

[Miruna Curtean]

Attachment: CannotRemove.gif

Tested using the method of adding the extension in the windows registry and then launching the browser.
Verified fixed with Windows 10 x 64 bit on Firefox Nightly 71.0a1 (Build ID:20191017093524)