1581058 - Another round of WebRender cleanups and documentation

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Comment 1

[Jessie [:jbonisteel] pls NI]

NI-ing Kvark here too because I know he has been interested in something along these lines, so maybe a potential to collaborate?

Comment 2

[Nicolas Silva [:nical]]

Attachment: Bug 1581058 - Rename a lot of scene building related structures. r=gw

We have been using the term "scene building" to talk about what's happening in display_list_flattener.rs. In practice, this operation takes a pretty flat serialized display list and produces a tree of pictures among other things, so "flattening" doesn't describe what's going on very well.
To address this, this commit renames a number of things:

• display_list_flattener.rs -> scene_buiding.rs
• DisplayListFlattener -> DisplayListBuilder
• DocumentStats -> SceneStats (moved in scene.rs)

FrameBuilder is split int two structures: BuiltScene and FrameBuilder. The former is created by the SceneBuilder on the scene builder thread and its sole purpose is to be WebRender's internal represnetation of scene. The latter exists only on the render backend thread and generates frames (accessing the scene if necessary).
In addition, the frame builder and built scene are not stored in an Option anymore on the render backend (this is the only change that goes beyond moving or renaming something).

Comment 3

[Nicolas Silva [:nical]]

Attachment: Bug 1581058 - Rename scene_builder::SceneBuilder into scene_builder_thread::SceneBuilderThread. r=gw

This will let us rename DisplayListFlattener appropriately in the next commit.

Comment 4

[Nicolas Silva [:nical]]

Attachment: Bug 1581058 - Move RenderTaskCache into its own module. r=gw

This way render_task.rs (a pretty large file still) is only about describing the specific render task types.

Comment 5

[Dzmitry Malyshau [:kvark]]

Thanks for bringing me in!

Hard to discuss the bug itself due to "No description provided.", but the changes attached look like a good improvement in the clarity of our modules and types. Let me know if I can help reviewing them ;)

Comment 6

[Nicolas Silva [:nical]]

Attachment: Bug 1581058 - Remove remaining use of the term "flattening". r=gw

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/362feebe585e
Move RenderTaskCache into its own module. r=gw
https://hg.mozilla.org/integration/autoland/rev/7a826f08cb7f
Rename scene_builder::SceneBuilder into scene_builder_thread::SceneBuilderThread. r=gw
https://hg.mozilla.org/integration/autoland/rev/5266eb5527a7
Rename a lot of scene building related structures. r=gw
https://hg.mozilla.org/integration/autoland/rev/37598891cea6
Remove remaining use of the term "flattening". r=gw

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/362feebe585e
https://hg.mozilla.org/mozilla-central/rev/7a826f08cb7f
https://hg.mozilla.org/mozilla-central/rev/5266eb5527a7
https://hg.mozilla.org/mozilla-central/rev/37598891cea6