1581068 - Stop loading modules twice

Status: NEW

(DevTools :: Netmonitor, defect, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Network monitor is using two loaders at the same time, which leads to duplicate loads (about ~44 modules is loaded twice!)

See also great explanation from Julian:
https://bugzilla.mozilla.org/show_bug.cgi?id=1580255#c3

Avoiding duplicate loads should have positive impact on performance.

Honza

Comment 1

[Julian Descottes [:jdescottes]]

(In reply to Jan Honza Odvarko [:Honza] (always need-info? me) from comment #0)

Avoiding duplicate loads should have positive impact on performance.

I just tested it on DAMP, and the impact is actually minimal https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=mozilla-central&newProject=try&newRevision=05a3c26fcf40835397ecf55ef738500669d5f430&originalSignature=1760367&newSignature=1759151&framework=12&selectedTimeRange=172800

Maybe other platforms will show different results.
In general I expected very little in terms of DAMP impact, but a little more than what shows on my push :)
Loading the modules twice makes us use a bit more memory, but probably not enough to show up in DAMP.
It should have improved netmonitor coldopen in theory, but that might be very small.

So we should not expect a big perf improvement from this.
The main added value is to avoid weird bugs such as the issue discussed in Bug 1580255