1581092 - Crash in [@ hncshellext64.dll]

Status: RESOLVED FIXED

(External Software Affecting Firefox :: Other, defect, P5)

Description

[Pascal Chevrel:pascalc]

This bug is for crash report bp-2b414824-950e-411f-8acd-c4e610190912.

Top 6 frames of crashing thread:

0 hncshellext64.dll hncshellext64.dll@0x12047 
1 hncshellext64.dll hncshellext64.dll@0xe87c 
2 hncshellext64.dll hncshellext64.dll@0xf762 
3 hncshellext64.dll hncshellext64.dll@0xfbb0 
4 hncshellext64.dll hncshellext64.dll@0xffc3 
5 hncshellext64.dll hncshellext64.dll@0x3c49f 

Comment 1

[Pascal Chevrel:pascalc]

The bulk of crashes are builds with the Korean locale.

Comment 2

[Marco Bonardo [:mak]]

I translated a few pages related to this dll, it looks like it's also causing crashes in Chrome and IE.
I think the library is part of "Hancom Office" (https://www.hancom.com/global/product/productWindowsMain.do). Because it's apparently a shell extension, I'll move to Shell Integration, feel free to move back if it doesn't apply.

Comment 3

[Gabriele Svelto [:gsvelto]]

We can blacklist this version of the DLL and move on. WDYT?

Comment 4

[Gabriele Svelto [:gsvelto]]

I scoured the crashes and they're all coming from one version of this DLL: 1.0.0.3. I can cook up a patch to block it in 30 secs but we'll have no way to test it. That being said there's crashes coming from nightly so if blocking works we should see its effects right away. Gian-Carlo would you be OK with blocking? It could really be a quick fix.

Comment 5

[Gian-Carlo Pascutto [:gcp]]

Yeah sounds fine, blocking a Shell Extension shouldn't cause much functionality loss I hope. Ask Toshihito for signoff.

Comment 6

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1581092 - Prevent the Hancom Office shell extension from crashing Firefox r=tkikuchi

Comment 7

[Gabriele Svelto [:gsvelto]]

Windows DLLBlocklist request form

1. How were we aware of the problem?
   Crash reports linked from this bug.

2. Is the product downloadable? If so, do we have a local repro?
   I couldn't find a way to download the product so we don't have a local repro.

3. What is the maximum version of the module in the crash reports?
   1.0.0.3, all crashes happen exactly on this version

4. Is the issue fixed by a newer version of the product?
   Using the third-party-module ping I found there are newer versions of this module (I found 1.0.0.4 and 1.0.0.6). None of these are found in the crash reports so the issue was most likely fixed in newer versions of the product.

5. Do we have data about the module in the third-party-module ping?
   We do have information for more recent versions, I couldn't find for the affected version.

6. Do we know how the module is loaded?
   It's being loaded via LoadLibraryWithLogging()

7. Describe your conclusion.
   I think we can block version 1.0.0.3 which is the only one responsible for crashes

Comment 8

[Toshihito Kikuchi [:toshi]]

Sweet!

(In reply to Gabriele Svelto [:gsvelto] from comment #7)

4. Is the issue fixed by a newer version of the product?
   Using the third-party-module ping I found there are newer versions of this module (I found 1.0.0.4 and 1.0.0.6). None of these are found in the crash reports so the issue was most likely fixed in newer versions of the product.

5. Do we have data about the module in the third-party-module ping?
   We do have information for more recent versions, I couldn't find for the affected version.

No way to check it, but maybe loading v1.0.0.3 crashes the process before sending a ping.. Anyway, I think these facts support our decision to block v1.0.0.3 or older.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b4a347ccc18
Prevent the Hancom Office shell extension from crashing Firefox r=tkikuchi

Comment 10

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/7b4a347ccc18