1581119 - Flex highlighter doesn't adjust color of pattern

Status: RESOLVED FIXED

(DevTools :: Inspector: Layout, defect, P2)

Description

[Martin Balfanz [:mbalfanz]]

Attachment: Screenshot 2019-09-13 at 15.05.22.png

STR:

1. While on bugzilla, inspect #page-toolbar
2. Toggle the flex highlighter on
3. Change the highlighter color

ER: Color of both lines and background pattern should change

AR: Only color of lines changes, background pattern remains the same

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

This is happening because we cache these patterns and their color. https://searchfox.org/mozilla-central/source/devtools/server/actors/highlighters/flexbox.js#243,249,292,298.

A potential fix is to store the previous color, and when that changes, we invalidate and remove all the patterns in these caches. We would make this change inside of _update() just before we render the lines. https://searchfox.org/mozilla-central/source/devtools/server/actors/highlighters/flexbox.js#865

Comment 2

[Mellina Yonashiro]

Hi everyone,

Could I give this a try?

Thanks!

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

(In reply to Mellina Yonashiro from comment #2)

Hi everyone,

Could I give this a try?

Thanks!

Yes, of course. Please let me know if I can help.

Comment 5

[Mellina Yonashiro]

Thanks, Gabriel.

I had some issues building Firefox, but things are working now. I will have a look at this bug as soon as it is done.

Comment 6

[Mellina Yonashiro]

Attachment: Bug 1581119 - Flex highlighter doesn't adjust color of pattern r=gl

Comment 7

[Patrick Brosset <:pbro>]

Hi Mellina, it looks like Gabriel made a few last comments in phabricator about your patch. Are you still planning on working on it?
If you just need more time, that's totally fine. Just let us know.

Comment 8

[Mellina Yonashiro]

Hi Patrick, sorry for the late reply.
I saw it, but I didn't have time to look at it. I have time tomorrow and will work on it.
Sorry again.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a9dba929c84
Flex highlighter doesn't adjust color of pattern r=gl

Comment 10

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/3a9dba929c84