1581149 - switch to new GCP shipitit-workers

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, task)

Description

[Mihai Tabara [:mtabara]⌚️GMT]

Turns out we can switch shipitscript-workers to GCP! \o/

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Bug 1581149 - switch to new GCP shipitworkers. r=catlee a=release

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

I triggerred https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=267974740&revision=d3523b595fa3e3d3872fdc2a39b7b02beeda5a7b to test these changes against the dev instances and task failed with

'additionalProperties': False}}, 'required': ['dependencies', 'scopes', 'payload']}
Traceback (most recent call last):
  File "/app/bin/shipitscript", line 11, in <module>
    load_entry_point('shipitscript', 'console_scripts', 'shipitscript')()
  File "/app/shipitscript/script.py", line 62, in main
    should_validate_task=False,
  File "/app/lib/python3.7/site-packages/scriptworker/client.py", line 164, in sync_main
    loop.run_until_complete(_handle_asyncio_loop(async_main, context))
  File "/usr/local/lib/python3.7/asyncio/base_events.py", line 579, in run_until_complete
    return future.result()
  File "/app/lib/python3.7/site-packages/scriptworker/client.py", line 204, in _handle_asyncio_loop
    await async_main(context)
  File "/app/shipitscript/script.py", line 22, in async_main
    context.ship_it_instance_config = get_ship_it_instance_config_from_scope(context)
  File "/app/shipitscript/task.py", line 29, in get_ship_it_instance_config_from_scope
    configured_instance = context.config['shipit_instance']
KeyError: 'shipit_instance'
exit code: 1

I suspect there's some cleanup stuff we still need to do in shipitscript to make this work, I'm looking into this now.

Comment 3

[Mihai Tabara [:mtabara]⌚️GMT]

Green task after I merged lattest master to dev. Landing this.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aade2a340f41
switch to new GCP shipitworkers. r=catlee a=release

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/aade2a340f41

Comment 6

[Mihai Tabara [:mtabara]⌚️GMT]

Grafted to beta too https://hg.mozilla.org/releases/mozilla-beta/rev/088fd9b69000a6af80173ea0afacf345252c0a12