1581174 - [Megabar] When opening a new window, Megabar jerks/expands from the middle to the right

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Mehmet]

Attachment: screencast.mov

Nightly 71.0a1 (2019-09-13)

STR:

1.) Enable Megabar
2.) Open a new Window

Actual: Megabar jerks/expands from the middle to the right

Expected: Smooth animation.

A screencast is attached.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1581174 - Ensure the urlbar extend animation doesn't run when opening a new window. r=harry

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9406858166b6
Ensure the urlbar extend animation doesn't run when opening a new window. r=harry

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9406858166b6

Comment 4

[Shane Hughes [:aminomancer]]

Is this still applicable? At least for me, the UrlbarView doesn't open in the first place when opening a new window. It's focused but not open, just as when opening a new tab. Is this tied to a pref, or has this just changed? What I'm seeing instead is that the animation kind of jerks when the UrlbarView first opens for each window. On the first open, it gains its breakout-extend-animate attribute a frame later which causes the animation to play after the UrlbarView has already been drawn. So it opens at 100% height and then scales down briefly before scaling back up. After that, every other time it opens will be fine since it keeps the breakout-extend-animate attribute. So it's just the first time that looks janky. So, I think maybe this attribute should be removed, unless I'm missing something.

Comment 5

[Shane Hughes [:aminomancer]]

If you make the animation's @keyframes definition much more exaggerated you can see the issue more clearly.

@keyframes urlbar-grow {
  0% {
    transform: scaleX(.6) scaleY(.3);
  }
  100% {
    transform: scale(1.0);
  }
}

This should make it more apparent what's going on

Comment 6

[Petruta Horea [:phorea], Desktop QA]

(In reply to aminomancer from comment #4)

Is this still applicable?

This issue was fixed and closed two years ago.
The animation was removed from the current Firefox versions.
Please file a new bug for the issue you're mentioning. Thank you!

Comment 7

[Shane Hughes [:aminomancer]]

The attribute and animation still exist, it's just changed