1581337 - When replying to an e-mail: Deleting a character or marked area in a quote ([Del] or [Backspace]) removes the entire quote.

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P1)

Description

[Alfred Peters [:infofrommozilla]]

STR:

• Reply to an e-mail
• Move the cursor into the quote or select some quote
• type [Del] or [Backspace]

Result: The whole quote will be removed.

This is a regression by:
| b60769450e9db6e7ffcf7c80efa8d037d5004b66: Bug 1574852 - part 101: Move HTMLEditRules::DidDeleteSelection() to HTMLEditor r=m_kato
| Masayuki Nakano <[e-mail]> - Thu, 12 Sep 2019 07:27:30 +0000 - rev 492783
| Push 36567 by [e-mail] at Thu, 12 Sep 2019 21:52:31 +0000
| Bug 1574852 - part 101: Move HTMLEditRules::DidDeleteSelection() to HTMLEditor r=m_kato
|
| Differential Revision: https://phabricator.services.mozilla.com/D45295

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thank you very much for reporting with the regression point! You're right. This is my simple mistake but without your investigation, I couldn't fix this so soon.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1581337 - Make `HTMLEditor::DeleteMostAncestorMailCiteElementIfEmpty()` do nothing if found mail-cite element is not empty

When rewriting DeleteMostAncestorMailCiteElementIfEmpty() with early-return
style, I forgot to make it do nothing when found element is empty:
https://searchfox.org/mozilla-central/rev/94e642e6036dc694b07cab895c9b5b267f0db065/editor/libeditor/HTMLEditRules.cpp#4078
This patch restores it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bcaada0fa740
Make `HTMLEditor::DeleteMostAncestorMailCiteElementIfEmpty()` do nothing if found mail-cite element is not empty r=m_kato

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/bcaada0fa740

Comment 6

[Jean-Philippe MENGUAL]

I confirm the bug is fixed.

Is there a non-regression test implemented?

Thanks

Comment 7

[Jorg K (CEST = GMT+2)]

Thanks for testing. A test was added now, see: https://hg.mozilla.org/mozilla-central/rev/bcaada0fa740#l2.12

Comment 8

[Jean-Philippe MENGUAL]

I go on testing. Not sure I did not speak so quickly. But I have just updated, maybe I should wait for the next build. So now if I delete a char from my own reply, ok. If I delete from the original message, it disappears. I let you informed tomorrow after the next build is available.

Comment 9

[Jorg K (CEST = GMT+2)]

As far as I can see, this works now, EDIT but the behaviour of forward-deleting into a quote has changed. It seems to delete the <blockquote> element when before, it didn't.
Scrap that second part. Looks like forward delete into a quote hasn't changed. The behaviour depends on the content of the quote.

Comment 10

[Jean-Philippe MENGUAL]

Ok the last build works. And if there is a non-reg test, great! Many thanks