Closed Bug 1581447 Opened 6 years ago Closed 6 years ago

Event breakpoints ignore blackboxed files

Categories

(DevTools :: Debugger, defect, P2)

defect

Tracking

(firefox71 fixed)

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: Harald, Assigned: bmiriam1230)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

What were you doing?

  1. Open Debugger on http://localhost:3000/#bugs
  2. Enable Event BPs for Keyboard
  3. Type a search in the site
  4. Pauses …
  5. Blackbox react-dom.production.min.js
  6. Continue and search again

What happened?

Pauses again in react-dom.production.min.js, menu confirms that the file is blackboxed (by offering to unblackbox it)

What should have happened?

Pause in the react class that handles keydown.

Anything else we should know?

Bug 1580374 affected DOM BPs similarly. Without this working it is nearly impossible to find the right event handler.

Blocks: dbg-blackbox

I can submit a patch for this. We need to pass in line and column to isBlackBoxed for this to work properly.

Pushed by dwalsh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/195277db19c5 Fix event breakpoints ignoring blackboxed files. r=davidwalsh
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Assignee: nobody → bmiriam1230
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: