Do not use synthetic display-inside values.
Categories
(Core :: Layout, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox73 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
Details
Attachments
(3 files)
Use just flow
since it doesn't simplify the layout code as much.
Also this patch should improve correctness of display: inline list-item
.
Assignee | ||
Comment 1•5 years ago
|
||
This matches the new servo layout engine too, and thus removes some #[cfg]
gunk.
Just use flow
since it doesn't simplify the layout code as much. Also this
patch should improve correctness of display: inline list-item
, as checking
for equality with display: inline
is incorrect in ~all cases.
Comment 3•5 years ago
|
||
The priority flag is not set for this bug.
:dbaron, could you have a look please?
For more information, please visit auto_nag documentation.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
Ping on this and the other couple patches? I replied in the Phab.
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0ef0c5a2e38a Use DisplayInside() / DisplayOutside() a bit more. r=mats
Assignee | ||
Comment 6•5 years ago
|
||
Comment 7•5 years ago
|
||
bugherder |
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/36ab7b5bb185 Fix checks for display: inline{,-block} which don't account for inline list items. r=mats
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/19659 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Comment 11•5 years ago
|
||
bugherder |
Upstream PR merged by moz-wptsync-bot
Updated•5 years ago
|
Assignee | ||
Comment 13•5 years ago
|
||
Mats, any update on the remaining patch?
It's been sitting on your queue for more than two weeks and I'd like to either land it or get rid of it and close this bug as WONTFIX... Though I think the patch is worth it.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Comment 14•5 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2ad2cad65c87 Do not use synthetic display-inside values. r=TYLin
Comment 15•5 years ago
|
||
bugherder |
Description
•