1581467 - Do not use synthetic display-inside values.

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Emilio Cobos Álvarez [:emilio]]

Use just flow since it doesn't simplify the layout code as much.

Also this patch should improve correctness of display: inline list-item.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1581467 - Do not use synthetic display-inside values. r=mats

This matches the new servo layout engine too, and thus removes some #[cfg]
gunk.

Just use flow since it doesn't simplify the layout code as much. Also this
patch should improve correctness of display: inline list-item, as checking
for equality with display: inline is incorrect in ~all cases.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1581467 - Use DisplayInside() / DisplayOutside() a bit more.

And remove some unused display values from the C++ bindings.

Comment 3

[BugBot [:suhaib / :marco]]

The priority flag is not set for this bug.
:dbaron, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Ping on this and the other couple patches? I replied in the Phab.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ef0c5a2e38a
Use DisplayInside() / DisplayOutside() a bit more. r=mats

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1581467 - Fix checks for display: inline{,-block} which don't account for inline list items.

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/0ef0c5a2e38a

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36ab7b5bb185
Fix checks for display: inline{,-block} which don't account for inline list items. r=mats

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/19659 for changes under testing/web-platform/tests

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 11

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/36ab7b5bb185

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 13

[Emilio Cobos Álvarez [:emilio]]

Mats, any update on the remaining patch?

It's been sitting on your queue for more than two weeks and I'd like to either land it or get rid of it and close this bug as WONTFIX... Though I think the patch is worth it.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ad2cad65c87
Do not use synthetic display-inside values. r=TYLin

Comment 15

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/2ad2cad65c87