1581477 - Mochitests fail when Fission on under no-sw-e10s mode, but pass under sw-e10s.

Status: RESOLVED WORKSFORME

(Core :: DOM: Service Workers, defect, P2)

Description

[Eden Chuang[:edenchuang]]

Following mochitests fail with Fission under the non-sw-e10s mode, but pass under the sw-e10s mode

dom/serviceworkers/test/test_csp_upgrade-insecure_intercept.html
dom/serviceworkers/test/test_hsts_upgrade_intercept.html
dom/serviceworkers/test/test_https_fetch.html
dom/serviceworkers/test/test_https_fetch_cloned_response.html
dom/serviceworkers/test/test_https_synth_fetch_from_cached_sw.html
dom/serviceworkers/test/test_importscript_mixedcontent.html
dom/serviceworkers/test/test_third_party_iframes.html

All function checks are passed, but the test environment complains that the service worker is not cleaned up after calling SimpleTest.finish().

Andrew, since we are turning on sw-e10s mode in nightly, do you think need we fix this bug at the moment? Or we just let it be fixed by turning on sw-e10s?

Comment 1

[Eden Chuang[:edenchuang]]

After fixed bug 1542415, following mochitests get into the same situation.

dom/serviceworkers/test/test_https_origin_after_redirect.html
dom/serviceworkers/test/test_https_origin_after_redirect_cached.html

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Let the bugs be fixed by turning on sw-e10s.

Comment 3

[Kris Maglione [:kmag]]

(In reply to Andrew Sutherland [:asuth] (he/him) from comment #2)

Let the bugs be fixed by turning on sw-e10s.

Yeah, we've already decided that sw-e10s is going to be required for Fission, and Fission mochitests are now running exclusively with sw-e10s and DocumentChannel enabled.

Comment 4

[Eden Chuang[:edenchuang]]

Currently, sw-e10s is on in default in nightly. I am going to enable the failed tests to see if they still fail with enable-fission.

Comment 5

[Neha Kochar [:neha]]

Eden, can all the tests that were waiting for sw-e10s pref now be enabled? I believe there are at least 8 tests in this category.

Comment 6

[Eden Chuang[:edenchuang]]

Hello Neha, Yes, I tested them, most of these can be passed on try, I will land a patch to enable them later.

Comment 7

[Eden Chuang[:edenchuang]]

Attachment: Enable dom/serviceworkers/test mochitests for fission

After sw-e10s enabled in nightly, following tests should be passsed with Fission

dom/serviceworkers/test/browser_devtools_serviceworker_interception.js
dom/serviceworkers/test/test_cookie_fetch.html
dom/serviceworkers/test/test_csp_upgrade-insecure_intercept.html
dom/serviceworkers/test/test_eventsource_intercept.html
dom/serviceworkers/test/test_hsts_upgrade_intercept.html
dom/serviceworkers/test/test_https_fetch.html
dom/serviceworkers/test/test_https_fetch_cloned_response.html
dom/serviceworkers/test/test_https_origin_after_redirect.html
dom/serviceworkers/test/test_https_origin_after_redirect_cached.html
dom/serviceworkers/test/test_https_synth_fetch_from_cached_sw.html
dom/serviceworkers/test/test_importscript_mixedcontent.html
dom/serviceworkers/test/test_sanitize_domain.html

This patch enables these tests.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/243d10dad9d8
Enable dom/serviceworkers/test mochitests for fission r=perry

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/243d10dad9d8

Comment 10

[Chris Peterson [:cpeterson]]

Roll unfixed test bugs from Fission Milestone M4 to M4.1

Comment 11

[Eden Chuang[:edenchuang]]

Attachment: enable dom/serviceworkers/test/test_third_party_iframes.html for fission

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dae278cd682d
enable dom/serviceworkers/test/test_third_party_iframes.html for fission r=dom-workers-and-storage-reviewers,perry

Comment 13

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/dae278cd682d