Closed Bug 1581506 Opened 5 years ago Closed 5 years ago

The "Get your passwords on your other devices" text exceed the header area on localized builds if the browser is horizontally resized

Categories

(Firefox :: about:logins, defect, P3)

Product:
Firefox
Component:
about:logins
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 71
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox69 --- disabled
firefox70 --- wontfix
firefox71 --- verified

People

(Reporter: srosu, Assigned: jaws)

References

Details

(Whiteboard: [passwords:management] [skyline])

Attachments

(2 files)

lockwise.png
44.44 KB, image/png
Details
Bug 1581506 - Hide the extra text for the Firefox Accounts button if the text wrapping stretches across more than three lines. r?sfoster
47 bytes, text/x-phabricator-request
Details | Review
Attached image lockwise.png —

[Affected versions]:

  • Nightly 71.0a1 (2019-09-75) (64-bit)
  • Beta 70.0b6

[Affected Platforms]:

  • Windows 10 x64
  • Mac 10.14
  • Ubuntu 16.04 x64.

[Prerequisites]:

  • Have a Firefox Beta 70.0b6 it build.
  • Have a Firefox profile where you are not logged into a FxA account.

[Steps to reproduce]:

  1. Open the Beta 70.0b3 Italian build with the profile from prerequisites.
  2. Navigate to "about:logins" page.
  3. Resize the browser horizontally.
  4. Observe the "Get your passwords on your other devices" text.

[Expected result]:

  • The text is correctly displayed and doesn't exceed the header area.

[Actual result]:

  • The text exceed the header area.

[Notes]:

  • Attached a screenshot with the issue.

With bug 1578407 fixed, this is harder to reproduce but is still an issue. We should hide the text when the window is too narrow.

Priority: -- → P3
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #9100569 - Attachment description: Bug 1581506 - Hide the extra text for the Firefox Accounts button if the text wrapping becomes taller than the 'sign in' button. r?sfoster → Bug 1581506 - Hide the extra text for the Firefox Accounts button if the text wrapping stretches across more than three lines. r?sfoster
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/be74a47ce669 Hide the extra text for the Firefox Accounts button if the text wrapping stretches across more than three lines. r=sfoster

https://hg.mozilla.org/mozilla-central/rev/be74a47ce669

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

I have verified this issue on the latest Nightly 71.0a1 (Build ID: 20191015213743) on Windows 10 x64, Mac 10.14, Ubuntu 16.04 x64.

  • The "Get your passwords on your other devices" text is correctly displayed and doesn't exceed the header area on localized builds if the browser is horizontally resized.
Status: RESOLVED → VERIFIED
status-firefox71: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: