1581544 - [protection-report] Graph bars displayed too small

Status: RESOLVED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[Erica Wright [:ewright]]

Attachment: Screen Shot 2019-09-16 at 10.38.39 AM.png

The graph is built in such a way that one bar (if larger than 100 trackers) should always fill 100% of the height, and the other bars are created relative to the tallest.

I have seen a graph where none of the bars fill the entire height of the graph area. screenshot attached.

Comment 1

[Erica Wright [:ewright]]

Attachment: Bug 1581544 - Use data from 1 week, not 8 days.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/474de32786de
Use data from 1 week, not 8 days. r=johannh

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/474de32786de

Comment 4

[Erica Wright [:ewright]]

Comment on attachment 9093100 [details]
Bug 1581544 - Use data from 1 week, not 8 days.

Beta/Release Uplift Approval Request

• User impact if declined: Visual issue, the graph may not fill the full space if the most trackers blocked were 7 days ago.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very simple straightforward change of one number. Check 6 days ago instead of 7, we were looking at an extra day of data.
• String changes made/needed: none

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9093100 [details]
Bug 1581544 - Use data from 1 week, not 8 days.

Minor visual change for the Protection Report. Approved for 70.0b8.

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/023ff6b1144f