Closed Bug 1581544 Opened 3 months ago Closed 3 months ago

[protection-report] Graph bars displayed too small

Categories

(Firefox :: Protections UI, defect, P1)

71 Branch
defect

Tracking

()

RESOLVED FIXED
Firefox 71
Tracking Status
firefox70 --- fixed
firefox71 --- fixed

People

(Reporter: ewright, Assigned: ewright)

References

(Blocks 1 open bug)

Details

(Whiteboard: [protection-report][skyline])

Attachments

(2 files)

The graph is built in such a way that one bar (if larger than 100 trackers) should always fill 100% of the height, and the other bars are created relative to the tallest.

I have seen a graph where none of the bars fill the entire height of the graph area. screenshot attached.

Assignee: nobody → ewright
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [protection-report][triage] → [protection-report][skyline]
Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/474de32786de
Use data from 1 week, not 8 days. r=johannh
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Comment on attachment 9093100 [details]
Bug 1581544 - Use data from 1 week, not 8 days.

Beta/Release Uplift Approval Request

  • User impact if declined: Visual issue, the graph may not fill the full space if the most trackers blocked were 7 days ago.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Very simple straightforward change of one number. Check 6 days ago instead of 7, we were looking at an extra day of data.
  • String changes made/needed: none
Attachment #9093100 - Flags: approval-mozilla-beta?

Comment on attachment 9093100 [details]
Bug 1581544 - Use data from 1 week, not 8 days.

Minor visual change for the Protection Report. Approved for 70.0b8.

Attachment #9093100 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.