1581565 - The React extension confuses breakpoints in HTML files

Status: NEW

(DevTools :: Debugger, defect, P2)

Description

[Jason Laster [:jlast]]

STR:

1. go to http://janodvarko.cz/xhr-spy/
2. add a breakpoint in xhr-spy/(index) on line 80
3. refresh

ER:

• pause on 80
• see the breakpoint in the editor and panel

AR:

• pause
• file does not load
• breakpoint does not appear in the panel

Comment 1

[Jason Laster [:jlast]]

Brian, could you look into this?

Comment 2

[Brian Hackett [Laid off!]]

I just tried this a couple times on autoland tip and can't reproduce it. How often does this happen for you?

Comment 3

[Jason Laster [:jlast]]

here's a quick video -- https://www.loom.com/share/ce651fbe535344058c04e71f8bc6b684

it requires react devtools to be installed

it looks like loadSourceText works, so not sure where it is failing yet, but the server seems fine

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I was able to reproduce a problem immediately after installing React DevTools add-on. No Firefox Restart, no Toolbox reopen.
But, slightly different observation:

• The BP icon in the gutter disappeared
• The BP was still hit
• The BP was not in the list of BPs (in the side panel)
• I can see the source

(Cache disabled in the Network panel)

There must be some racing since it's hard to reproduce again.

Honza

Comment 5

[Jason Laster [:jlast]]

lowering the priority because it requires several things to be true (react addons, disabled cache, and html files)

Comment 6

[Logan Smyth [:loganfsmyth]]

This seems to work for me on Nightly, Jason could you verify?