1581577 - Hostname obfuscation ICE duration telemetry is being reported in milliseconds, not seconds

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P2)

Description

[Dan Minor [:dminor]]

When I added the hostname obfuscation ICE duration telemetry in Bug 1569250, I intended for it to be reported in seconds and set the "high" value accordingly, but used the Telemetry::AccumulateTimeDelta call to report it, which reports in milliseconds.

Comment 1

[Dan Minor [:dminor]]

Attachment: Bug 1581577 - Fix ICE duration telemetry high value; r=bwc!

The Telemetry::AccumulateTimeDelta function reports in milliseconds but I had
assumed seconds when I added the hostname obfuscation ICE duration histogram.
This change adjusts the "high" value accordingly.

With the telemetry we've collected to date, 60% of the values are below 600
milliseconds, so I think that setting a high value of 30 seconds should be
sufficient even if there is a long tail. Since this does not change the data
being collected, no additional data-review is required, but it does require
renaming the key.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2591b1d2429d
Fix ICE duration telemetry high value; r=bwc

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/2591b1d2429d

Comment 4

[Dan Minor [:dminor]]

Comment on attachment 9093076 [details]
Bug 1581577 - Fix ICE duration telemetry high value; r=bwc!

Beta/Release Uplift Approval Request

• User impact if declined: This fixes the telemetry added in Bug 1581577 to have a proper high value for the ice duration, without this, we won't have the full range of values visible in telemetry which would make it harder to determine if enabling hostname obfuscation causes problems.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1569250
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This just changes a telemetry probe. It has been checked on Nightly already.
• String changes made/needed: None

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9093076 [details]
Bug 1581577 - Fix ICE duration telemetry high value; r=bwc!

Follow-up fix for bug 1569250. Approved for 70.0b8.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/ea623101ca50