Closed Bug 1581606 Opened 3 months ago Closed 2 months ago

Consider all monitors screen size when deciding to enable WebRender

Categories

(Core :: Graphics: WebRender, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox-esr68 --- disabled
firefox69 --- wontfix
firefox70 --- fixed
firefox71 --- fixed

People

(Reporter: aosmond, Assigned: aosmond)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We currently disable WebRender when the screen size is too large for some configurations. We should actually take all monitors into consideration when making this decision, not just the primary monitor.

Summary: Consider all monitors screen sizewhen deciding to enable WebRender → Consider all monitors screen size when deciding to enable WebRender

Before this patch, we only considered the primary screen when deciding
whether or not WebRender should be enabled. This is problematic for
Intel users where we don't want to turn on WebRender for large screens;
several small monitors are just as bad as one large screens. Now we add
up the pixel count for all the monitors when making this decision.

Pushed by aosmond@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b50fcb49160
Consider all screens when deciding to turn on WebRender. r=jrmuizel
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71

Is this needed on Beta for the Intel WebRender rollout? If so, Fx70 RC week is next week, so it'll need to be uplifted soon.

Flags: needinfo?(aosmond)

Comment on attachment 9093128 [details]
Bug 1581606 - Consider all screens when deciding to turn on WebRender.

Beta/Release Uplift Approval Request

  • User impact if declined: May get WebRender when it may be too slow.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Makes users less likely to get WebRender, but only if they have multiple monitors with Intel graphics cards.
  • String changes made/needed:
Flags: needinfo?(aosmond)
Attachment #9093128 - Flags: approval-mozilla-beta?

Comment on attachment 9093128 [details]
Bug 1581606 - Consider all screens when deciding to turn on WebRender.

Good idea. Let's uplift for beta 14.

Attachment #9093128 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.