1581614 - Extract service container

Status: RESOLVED FIXED

(DevTools :: Console, task, P1)

Description

[Jason Laster [:jlast]]

It wold be nice if the servicecontainer were in its own module so that it is easier to manage the dependencies it has on the rest of the console panel.

Comment 1

[Jason Laster [:jlast]]

Attachment: Bug 1581614 - Extract service container. r=nchevobbe

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93a5266e6f1c
Extract service container. r=nchevobbe

Comment 3

[Raul Gurzau (:RaulG)]

Backed out changeset 93a5266e6f1c (bug 1581614) for devtools failures e.g browser_browser_toolbox.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/5a6eae3095a520c5155fb0fa3d33f1c0ea45ba3a

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=93a5266e6f1c8a537e8df17e41b7638ec4989426&selectedJob=267560421

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=267560421&repo=autoland&lineNumber=1753

Log snippet:
[task 2019-09-20T00:53:45.717Z] 00:53:45 INFO - TEST-INFO | started process screencapture
[task 2019-09-20T00:53:45.880Z] 00:53:45 INFO - TEST-INFO | screencapture: exit 0
[task 2019-09-20T00:53:45.881Z] 00:53:45 INFO - Buffered messages logged at 00:47:45
[task 2019-09-20T00:53:45.881Z] 00:53:45 INFO - Entering test bound
[task 2019-09-20T00:53:45.881Z] 00:53:45 INFO - TEST-PASS | devtools/client/framework/test/browser_browser_toolbox.js | No session state initially -
[task 2019-09-20T00:53:45.881Z] 00:53:45 INFO - Opening the browser toolbox
[task 2019-09-20T00:53:45.881Z] 00:53:45 INFO -
[task 2019-09-20T00:53:45.881Z] 00:53:45 INFO - TEST-PASS | devtools/client/framework/test/browser_browser_toolbox.js | Browser toolbox started
[task 2019-09-20T00:53:45.882Z] 00:53:45 INFO - -
[task 2019-09-20T00:53:45.882Z] 00:53:45 INFO - TEST-PASS | devtools/client/framework/test/browser_browser_toolbox.js | Has session state -
[task 2019-09-20T00:53:45.882Z] 00:53:45 INFO - Buffered messages logged at 00:47:57
[task 2019-09-20T00:53:45.882Z] 00:53:45 INFO - Console message: [JavaScript Warning: "The Web Console logging API (console.log, console.info, console.warn, console.error) has been disabled by a script on this page."]
[task 2019-09-20T00:53:45.882Z] 00:53:45 INFO - Buffered messages logged at 00:49:15
[task 2019-09-20T00:53:45.883Z] 00:53:45 INFO - Longer timeout required, waiting longer... Remaining timeouts: 3
[task 2019-09-20T00:53:45.883Z] 00:53:45 INFO - Buffered messages logged at 00:50:45
[task 2019-09-20T00:53:45.883Z] 00:53:45 INFO - Longer timeout required, waiting longer... Remaining timeouts: 2
[task 2019-09-20T00:53:45.883Z] 00:53:45 INFO - Buffered messages logged at 00:52:15
[task 2019-09-20T00:53:45.884Z] 00:53:45 INFO - Longer timeout required, waiting longer... Remaining timeouts: 1
[task 2019-09-20T00:53:45.884Z] 00:53:45 INFO - Buffered messages finished
[task 2019-09-20T00:53:45.884Z] 00:53:45 INFO - TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_browser_toolbox.js | Test timed out -
[task 2019-09-20T00:53:45.884Z] 00:53:45 INFO - GECKO(1671) | MEMORY STAT | vsize 7674MB | residentFast 391MB | heapAllocated 100MB
[task 2019-09-20T00:53:45.884Z] 00:53:45 INFO - TEST-OK | devtools/client/framework/test/browser_browser_toolbox.js | took 360255ms
[task 2019-09-20T00:53:45.885Z] 00:53:45 INFO - GECKO(1671) | ++DOCSHELL 0x12390a800 == 1 [pid = 1679] [id = {38df6152-280f-c043-8e33-fcc1f032fb34}]
[task 2019-09-20T00:53:45.885Z] 00:53:45 INFO - GECKO(1671) | ++DOMWINDOW == 1 (0x114d63020) [pid = 1679] [serial = 1] [outer = 0x0]
[task 2019-09-20T00:53:45.885Z] 00:53:45 INFO - GECKO(1671) | ++DOMWINDOW == 2 (0x146b1fc00) [pid = 1679] [serial = 2] [outer = 0x114d63020]
[task 2019-09-20T00:53:45.885Z] 00:53:45 INFO - checking window state
[task 2019-09-20T00:53:45.885Z] 00:53:45 INFO - GECKO(1671) | must wait for focus

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64f03c0a528c
Extract service container. r=nchevobbe

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/64f03c0a528c