1581669 - Crashes in CALayerRetain on macOS 10.14

Status: RESOLVED WORKSFORME

(Core :: Graphics, defect, P3)

Description

[Steven Michaud [:smichaud] (Retired)]

These crashes seem to have started recently. Their number is still moderate (currently they're the #8 Mac topcrasher), but they seem to be growing.

https://crash-stats.mozilla.com/signature/?signature=CALayerRetain&date=%3E%3D2019-03-16T22%3A41%3A00.000Z&date=%3C2019-09-16T22%3A41%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_columns=startup_crash&_columns=platform_version&_sort=-date&page=1

Here's a representative crash stack:

0 QuartzCore CALayerRetain
1 QuartzCore CA::Layer::thread_flags_(CA::Transaction*)
2 QuartzCore CA::Layer::commit_if_needed(CA::Transaction*, void ()(CA::Layer,
unsigned int, unsigned int, void*), void*)
3 QuartzCore CA::Context::commit_root(CA::Layer*, void*)
4 QuartzCore CA::Context::commit_transaction(CA::Transaction*)
5 QuartzCore CA::Transaction::commit()
6 AppKit __65+[CATransaction(NSCATransaction)
NS_setFlushesWithDisplayRefresh]_block_invoke
7 CoreFoundation ___CFXPCCreateCFObjectFromXPCObject_block_invoke.9
8 CoreFoundation CFRunLoopRemoveObserver
9 CoreFoundation __CFRunLoopRun
10 CoreFoundation __CFTSRToDispatchTime
11 HIToolbox RunCurrentEventLoopInMode
12 HIToolbox ReceiveNextEventCommon
13 HIToolbox _BlockUntilNextEventMatchingListInModeWithFilter
14 AppKit _DPSNextEvent
15 AppKit -[NSApplication(NSEvent)
_nextEventMatchingEventMask:untilDate:inMode:dequeue:]
16 XUL -[GeckoNSApplication nextEventMatchingMask:untilDate:inMode:dequeue:]
widget/cocoa/nsAppShell.mm:169
17 AppKit -[NSApplication run]
18 XUL nsAppShell::Run() widget/cocoa/nsAppShell.mm:703
19 XUL nsAppStartup::Run() toolkit/components/startup/nsAppStartup.cpp:276
20 XUL XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&)
toolkit/xre/nsAppRunner.cpp:4735
21 XUL mozilla::BootstrapImpl::XRE_main(int, char**, mozilla::BootstrapConfig const&)
toolkit/xre/Bootstrap.cpp:45
22 firefox main browser/app/nsBrowserApp.cpp:300 frame_pointer
23 libdyld.dylib start

This bug might benefit from an analysis using a HookCase hook library (https://github.com/steven-michaud/HookCase).

Comment 1

[Jamie Nicol [:jnicol] (on leave until 21st October)]

Presumably a regression from bug 1574538 or related.

Comment 2

[Intermittent Failures Robot]

1 failures in 4530 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• macosx1014-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1581669&startday=2019-09-23&endday=2019-09-29&tree=all

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.