1581690 - scrollLeft is mistakenly a zero or negative value for a block-RTL element, and scrollTop is also mistakenly a zero or negative value for a block-RTL and inline-RTL element (orthogonal block; writing-mode: vertical-rl)

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, defect, P3)

Description

[David Burns :automatedtester]

When looking at https://github.com/web-platform-tests/wpt-metadata/blob/master/css/css-scroll-anchoring/META.yml#L9 I see that Bug 1447743 is referenced but is closed as complete. There are still failing tests for this in wpt for Firefox.

Dan, is this a bug from the previous bug or are we missing something and this needs to be triaged?

Comment 1

[Mats Palmgren (inactive)]

This test is just bogus isn't it? It doesn't reflect what the spec currently says and what Gecko and WebKit implements.
It's simply a bug in Blink, according to: https://github.com/w3c/csswg-drafts/issues/1354

Let's just fix the test:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=860aeaa1d10f61544355a6b899c21998ee6a5328

Comment 2

[Mats Palmgren (inactive)]

David, in reply to your question on IRC (TLDR: "it depends"), given that bug 1447743 is closed as invalid and the discussions in the linked csswg spec issues, it seems clear that this test is testing Blink's layout[1] which is wrong per spec. In this particular case I think that it could be spotted by anyone, not necessarily a Layout team member. In general though, it's probably hard to be certain a test is bogus unless you're familiar with the relevant spec (and follow spec discussions) and its implementation. However, there are some systematic errors in tests, like for example depending on the serialization of CSS shorthand properties (which causes many of the Grid "failures" listed in bug 1514265), which can be spotted (and fixed!) by anyone really.

([1] it appears Blink intends to fix it in https://bugs.chromium.org/p/chromium/issues/detail?id=721759)

Comment 3

[Mats Palmgren (inactive)]

Attachment: Bug 1581690 - Update test to reflect what the spec currently says. r=dholbert

It's currently testing Blink's layout which is wrong per spec.
See https://github.com/w3c/csswg-drafts/issues/1354 for background.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/881018043cba
Update test to reflect what the spec currently says.  r=dholbert

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/19140 for changes under testing/web-platform/tests

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/881018043cba

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot