Closed Bug 1581799 Opened 2 months ago Closed 2 months ago

color picker and element selector not working together

Categories

(DevTools :: Inspector, defect, P3)

71 Branch
defect

Tracking

(firefox71 fixed)

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: stefan.ivan.ivanisevic, Assigned: chittorashobhit)

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(2 files)

Attached image Screenshot_1.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

To reporoduce bug:

  • Open Inspect element
  • Select Color Picker and Element Picker (both to be active at the same time)

Actual results:

Color picker freezed and will not move, while element picker is working as it should.

Also, color picker does not allow scrolling while is activated

Expected results:

Well, maybe one should cancel the other. I do not know. It's up to you to decide what should be happening :)

Component: Untriaged → Inspector
Product: Firefox → DevTools

Thanks for filing. I consider this a bug so marking as Defect instead.
I think the best course of action would be for those tools to cancel each other as you mentioned.

This might be an easy enough bug to work on for someone with JS knowledge and new to the project.
If this is you, please take a look at our contributor docs first: https://docs.firefox-dev.tools/ and then feel free to ask any questions you need answers to, to get started.

I think a good starting point would be this part of the code where the eye-dropper starts. Somewhere in there we should try to cancel the element picker if it was started (which you can access via this.toolbox.nodePicker).

Status: UNCONFIRMED → NEW
Type: enhancement → defect
Ever confirmed: true
Keywords: good-first-bug
Priority: -- → P3
Whiteboard: [lang=js]

Hey Patrick! Thanks for posting this on slack. I'd like to take a look at this.

Ok thanks for wanting to help! Please let me know if comment 1 is enough to get started. If you have any further questions, here or on Slack are both fine.

Assignee: nobody → chittorashobhit
Status: NEW → ASSIGNED

(In reply to Patrick Brosset <:pbro> from comment #3)

Ok thanks for wanting to help! Please let me know if comment 1 is enough to get started. If you have any further questions, here or on Slack are both fine.

HI Patrick,
Thanks for the code pointer. I was able to fix the issue here and was able to disable the features as expected. I'm new to submitting code here, so I'm taking a look at arcanist to start the review.

Before this fix the user could turn on both, the color picker as well as the node picker / inspector.
That leads to the problem where in the node picker works fine but the color picker gets stuck at the
same place on the screen.

Attachment #9096811 - Attachment description: fix: disable node or color picker when one is on → Bug 1581799 - fix: disable node or color picker when one is on
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ec52c8aa2b8e
fix: disable node or color picker when one is on r=pbro
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in before you can comment on or make changes to this bug.