Closed Bug 1581886 Opened 5 years ago Closed 5 years ago

Intermittent toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | {

Categories

(WebExtensions :: General, defect, P5)

Product:
WebExtensions
Component:
General
Type:
defect

Tracking

(firefox-esr68 unaffected, firefox74 wontfix, firefox75 wontfix, firefox76 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla76
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox74 --- wontfix
firefox75 --- wontfix
firefox76 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: myeongjun.ko)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

Bug 1581886 - let theme.getCurrent() return an empty Theme instead of an empty object by default r=robwu
47 bytes, text/x-phabricator-request
Details | Review

Filed by: rgurzau [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=267052833&repo=autoland
Full log: https://queue.taskcluster.net/v1/task/OjrHwrjNTsG2bOULxSb_Aw/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/OjrHwrjNTsG2bOULxSb_Aw/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

[task 2019-09-17T14:46:20.363Z] 14:46:20 INFO - TEST-START | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js
[task 2019-09-17T14:46:20.450Z] 14:46:20 INFO - GECKO(9972) | [Parent 7928, Main Thread] WARNING: Need BrowserChild to get the nativeWindow from!: file z:/build/build/++DOCSHELL 0000023250370000 == 5 [pid = 8336] [id = {c7a5bf96-d0a1-4800-9e3a-14a626b8d9f8}]
[task 2019-09-17T14:46:20.450Z] 14:46:20 INFO - GECKO(9972) | src/widget/Pupp++DOMWINDOW == 13 (000002324ED36980) [pid = 8336] [serial = 13] [outer = 0000000000000000]
[task 2019-09-17T14:46:20.450Z] 14:46:20 INFO - GECKO(9972) | etWidget.cpp, line 1090
[task 2019-09-17T14:46:20.450Z] 14:46:20 INFO - GECKO(9972) | ++DOMWINDOW == 14 (000002325040B400) [pid = 8336] [serial = 14] [outer = 000002324ED36980]
[task 2019-09-17T14:46:20.479Z] 14:46:20 INFO - GECKO(9972) | [Child 8336, Main Thread] WARNING: Fallback to BasicLayerManager: file z:/build/build/src/dom/ipc/BrowserChild.cpp, line 2637
[task 2019-09-17T14:46:20.489Z] 14:46:20 INFO - GECKO(9972) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to c:\users\task_1568725757\appdata\local\temp\tmpgqr00r.mozrunner\runtests_leaks_tab_pid5372.log
[task 2019-09-17T14:46:20.494Z] 14:46:20 INFO - GECKO(9972) | ++DOMWINDOW == 15 (0000023250412400) [pid = 8336] [serial = 15] [outer = 000002324ED36980]
[task 2019-09-17T14:46:20.553Z] 14:46:20 INFO - TEST-INFO | started process screenshot
[task 2019-09-17T14:46:20.618Z] 14:46:20 INFO - TEST-INFO | screenshot: exit 0
[task 2019-09-17T14:46:20.618Z] 14:46:20 INFO - Buffered messages logged at 14:46:20
[task 2019-09-17T14:46:20.618Z] 14:46:20 INFO - Entering test bound test_get_current
[task 2019-09-17T14:46:20.619Z] 14:46:20 INFO - Extension loaded
[task 2019-09-17T14:46:20.619Z] 14:46:20 INFO - Testing getCurrent() with initial unthemed window
[task 2019-09-17T14:46:20.619Z] 14:46:20 INFO - Buffered messages finished
[task 2019-09-17T14:46:20.620Z] 14:46:20 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | {
[task 2019-09-17T14:46:20.620Z] 14:46:20 INFO - "colors": null,
[task 2019-09-17T14:46:20.620Z] 14:46:20 INFO - "images": null,
[task 2019-09-17T14:46:20.620Z] 14:46:20 INFO - "properties": null
[task 2019-09-17T14:46:20.620Z] 14:46:20 INFO - } - Expected: 0, Actual: 3 -
[task 2019-09-17T14:46:20.620Z] 14:46:20 INFO - Stack trace:
[task 2019-09-17T14:46:20.620Z] 14:46:20 INFO - chrome://mochikit/content/browser-test.js:test_ok:1580
[task 2019-09-17T14:46:20.620Z] 14:46:20 INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:testHandler:59
[task 2019-09-17T14:46:20.620Z] 14:46:20 INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:testResult:73
[task 2019-09-17T14:46:20.620Z] 14:46:20 INFO - resource://specialpowers/SpecialPowersChild.jsm:listener:2035
[task 2019-09-17T14:46:20.620Z] 14:46:20 INFO - resource://specialpowers/SpecialPowersChild.jsm:loadExtension/<:1977
[task 2019-09-17T14:46:20.620Z] 14:46:20 INFO - resource://specialpowers/SpecialPowersChild.jsm:receiveMessage:242
[task 2019-09-17T14:46:20.621Z] 14:46:20 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-09-17T14:46:20.621Z] 14:46:20 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | {
[task 2019-09-17T14:46:20.621Z] 14:46:20 INFO - "colors": null,
[task 2019-09-17T14:46:20.621Z] 14:46:20 INFO - "images": null,
[task 2019-09-17T14:46:20.621Z] 14:46:20 INFO - "properties": null
[task 2019-09-17T14:46:20.621Z] 14:46:20 INFO - } - Expected: 0, Actual: 3 -
[task 2019-09-17T14:46:20.621Z] 14:46:20 INFO - Stack trace:
[task 2019-09-17T14:46:20.621Z] 14:46:20 INFO - chrome://mochikit/content/browser-test.js:test_ok:1580

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INCOMPLETE

Re-opening because this is still a relevant issue, and a contributor has also reported this failure in https://phabricator.services.mozilla.com/D52148

[task 2019-09-17T14:46:20.621Z] 14:46:20 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | {
[task 2019-09-17T14:46:20.621Z] 14:46:20 INFO - "colors": null,
[task 2019-09-17T14:46:20.621Z] 14:46:20 INFO - "images": null,
[task 2019-09-17T14:46:20.621Z] 14:46:20 INFO - "properties": null
[task 2019-09-17T14:46:20.621Z] 14:46:20 INFO - } - Expected: 0, Actual: 3 -

The test is checking that the initial theme is an empty object, but ever since migrating built-in themes to WebExtensions (bug 1525762), this is no longer the case (bug 1542023).

Status: RESOLVED → REOPENED
Depends on: 1542023
Regressed by: 1525762
Resolution: INCOMPLETE → ---
Assignee: nobody → myeongjun.ko
Attachment #9122566 - Attachment description: Bug 1581886 - The test fails (toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js) r=robwu → Bug 1581886 - Reload default theme before starting test browser_ext_themes_dynamic_getCurrent.js r=robwu
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/83dc4a0b22d8
Reload default theme before starting test browser_ext_themes_dynamic_getCurrent.js r=robwu

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&searchStr=browser%2Cchrome&revision=83dc4a0b22d8f4a7f40c2f15fe0986acbff61639&selectedJob=287173504

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=287173504&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/9d608be114606985c5c19cdeaa5cd890c5f755db

[task 2020-02-01T17:20:28.338Z] 17:20:28 INFO - TEST-START | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js
[task 2020-02-01T17:20:28.475Z] 17:20:28 INFO - GECKO(8064) | [Parent 8064, Main Thread] WARNING: Need BrowserChild to get the nativeWindow from!: file /builds/worker/workspace/build/src/widget/PuppetWidget.cpp, line 1095
[task 2020-02-01T17:20:28.477Z] 17:20:28 INFO - GECKO(8064) | [Child 8121: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7faaab476000 == 5 [pid = 8121] [id = {316d2e6b-0acf-45e2-b203-dc191f3a1813}]
[task 2020-02-01T17:20:28.478Z] 17:20:28 INFO - GECKO(8064) | [Child 8121: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 9 (0x7faaa9e93880) [pid = 8121] [serial = 22] [outer = (nil)]
[task 2020-02-01T17:20:28.478Z] 17:20:28 INFO - GECKO(8064) | [Child 8121: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 10 (0x7faaa8e44c00) [pid = 8121] [serial = 23] [outer = 0x7faaa9e93880]
[task 2020-02-01T17:20:28.500Z] 17:20:28 INFO - GECKO(8064) | [Child 8121, Main Thread] WARNING: Fallback to BasicLayerManager: file /builds/worker/workspace/build/src/dom/ipc/BrowserChild.cpp, line 2739
[task 2020-02-01T17:20:28.515Z] 17:20:28 INFO - GECKO(8064) | [Child 8121, Main Thread] WARNING: Trying to request nsIHttpChannel from DocumentChannel, this is likely broken: file /builds/worker/workspace/build/src/netwerk/ipc/DocumentChannel.cpp, line 63
[task 2020-02-01T17:20:28.516Z] 17:20:28 INFO - GECKO(8064) | [Child 8121: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 11 (0x7faaa8e4a800) [pid = 8121] [serial = 24] [outer = 0x7faaa9e93880]
[task 2020-02-01T17:20:28.637Z] 17:20:28 INFO - GECKO(8064) | [Parent 8064: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 22 (0x7f98eb32f000) [pid = 8064] [serial = 9] [outer = (nil)] [url = about:blank]
[task 2020-02-01T17:20:28.637Z] 17:20:28 INFO - GECKO(8064) | [Parent 8064: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 21 (0x7f98eb3f7000) [pid = 8064] [serial = 4] [outer = (nil)] [url = about:blank]
[task 2020-02-01T17:20:28.658Z] 17:20:28 INFO - TEST-INFO | started process screentopng
[task 2020-02-01T17:20:29.245Z] 17:20:29 INFO - TEST-INFO | screentopng: exit 0
[task 2020-02-01T17:20:29.245Z] 17:20:29 INFO - Buffered messages logged at 17:20:28
[task 2020-02-01T17:20:29.245Z] 17:20:29 INFO - Entering test bound setup_default_theme
[task 2020-02-01T17:20:29.247Z] 17:20:29 INFO - Leaving test bound setup_default_theme
[task 2020-02-01T17:20:29.248Z] 17:20:29 INFO - Entering test bound test_get_current
[task 2020-02-01T17:20:29.248Z] 17:20:29 INFO - Extension loaded
[task 2020-02-01T17:20:29.249Z] 17:20:29 INFO - Testing getCurrent() with initial unthemed window
[task 2020-02-01T17:20:29.250Z] 17:20:29 INFO - Buffered messages finished
[task 2020-02-01T17:20:29.252Z] 17:20:29 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | {
[task 2020-02-01T17:20:29.252Z] 17:20:29 INFO - "colors": null,
[task 2020-02-01T17:20:29.252Z] 17:20:29 INFO - "images": null,
[task 2020-02-01T17:20:29.252Z] 17:20:29 INFO - "properties": null
[task 2020-02-01T17:20:29.252Z] 17:20:29 INFO - } - Expected: 0, Actual: 3 -
[task 2020-02-01T17:20:29.252Z] 17:20:29 INFO - Stack trace:
[task 2020-02-01T17:20:29.252Z] 17:20:29 INFO - chrome://mochikit/content/browser-test.js:test_ok:1292
[task 2020-02-01T17:20:29.253Z] 17:20:29 INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:testHandler:59
[task 2020-02-01T17:20:29.253Z] 17:20:29 INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:testResult:73
[task 2020-02-01T17:20:29.253Z] 17:20:29 INFO - resource://specialpowers/SpecialPowersChild.jsm:listener:2079
[task 2020-02-01T17:20:29.253Z] 17:20:29 INFO - resource://specialpowers/SpecialPowersChild.jsm:loadExtension/<:2021
[task 2020-02-01T17:20:29.253Z] 17:20:29 INFO - resource://specialpowers/SpecialPowersChild.jsm:receiveMessage:242
[task 2020-02-01T17:20:29.253Z] 17:20:29 INFO - JSWindowActor queryresource://specialpowers/SpecialPowersParent.jsm:resultListener:929
[task 2020-02-01T17:20:29.254Z] 17:20:29 INFO - resource://gre/modules/ExtensionCommon.jsm:emit:327
[task 2020-02-01T17:20:29.254Z] 17:20:29 INFO - resource://gre/modules/Extension.jsm:receiveMessage:1820
[task 2020-02-01T17:20:29.254Z] 17:20:29 INFO - MessageListener.receiveMessageresource://gre/modules/Extension.jsm:Extension:1642
[task 2020-02-01T17:20:29.254Z] 17:20:29 INFO - resource://testing-common/ExtensionTestCommon.jsm:generate:458
[task 2020-02-01T17:20:29.254Z] 17:20:29 INFO - resource://specialpowers/SpecialPowersParent.jsm:receiveMessage:926
[task 2020-02-01T17:20:29.254Z] 17:20:29 INFO - JSWindowActor query*resource://specialpowers/SpecialPowersChild.jsm:loadExtension:2071
[task 2020-02-01T17:20:29.254Z] 17:20:29 INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:ExtensionTestUtils.loadExtension:105
[task 2020-02-01T17:20:29.255Z] 17:20:29 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js:test_get_current:24
[task 2020-02-01T17:20:29.255Z] 17:20:29 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
[task 2020-02-01T17:20:29.255Z] 17:20:29 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2020-02-01T17:20:29.255Z] 17:20:29 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:925
[task 2020-02-01T17:20:29.255Z] 17:20:29 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:808
[task 2020-02-01T17:20:29.256Z] 17:20:29 INFO - Not taking screenshot here: see the one that was previously logged

Flags: needinfo?(myeongjun.ko)
Summary: Intermittent TV toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | { → Intermittent toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | {

Thank you. Let me check again.

In fact, with the wrong command[0], I failed all test locally.
I thought there was a problem only in my local. I'm sorry I didn't tell you in advance.
Thanks to this bug, I learned about TV.
Even if I run the correct command[1], the test continues to fail.
Please check again when your time is good.

[0]
./mach run <test> --verify

[1]
./mach test <test> --verify

Flags: needinfo?(myeongjun.ko) → needinfo?(rob)

In comment 3, I marked bug 1542023 as a blocking dependency of this bug. Before your change, the test passed because of the way that tests are run in automation (and with --verify). It failed when run once.

With your patch, the test will always fail as long as bug 1542023 is not fixed.

I looked at all public add-ons on addons.mozilla.org, and I can't find any add-on that behaves differently when theme.getCurrent() returns {colors: null, images: null, properties: null} instead of {}. So, let's fix the other bug by using that as the value for the "empty" theme, in tests and at https://searchfox.org/mozilla-central/rev/3811b11b5773c1dccfe8228bfc7143b10a9a2a99/toolkit/components/extensions/parent/ext-theme.js#25 .

Flags: needinfo?(rob)

Thank you very much for checking this problem.
Let me know when you're done making a decision. I'll proceed as follows.
Instead of {}, I'll change it to {colors: null, images: null, properties: null} on code[0] and change the relevant test again.

[0]
https://searchfox.org/mozilla-central/rev/3811b11b5773c1dccfe8228bfc7143b10a9a2a99/toolkit/components/extensions/parent/ext-theme.js#25

I missed request information.
Please check the above comment and let me know :)

Flags: needinfo?(rob)

Proceed with the implementation that I suggested in comment 11 and that you confirmed in comment 12.

Flags: needinfo?(rob)
Attachment #9122566 - Attachment description: Bug 1581886 - Reload default theme before starting test browser_ext_themes_dynamic_getCurrent.js r=robwu → Bug 1581886 - The empty values were changed to clean up test failure r=robwu
Attachment #9122566 - Attachment description: Bug 1581886 - The empty values were changed to clean up test failure r=robwu → Bug 1581886 - let theme.getCurrent() return an empty Theme instead of an empty object by default r=robwu
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1494b28cea80
let theme.getCurrent() return an empty Theme instead of an empty object by default r=robwu

There is test code that I should modify at latest version.
The reason for the modification is the same as above. (Because empty theme result is modified)

Should I merge the current patch into the latest version, modify error and submit again?
This is my first time submitting a patch after the merger, so I will proceed after confirmation.

Flags: needinfo?(myeongjun.ko) → needinfo?(rob)

You should update the existing revision, let me review it, and if I approve, add checkin-needed again.

Flags: needinfo?(rob)
Pushed by aiakab@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c40d0c42dee6
let theme.getCurrent() return an empty Theme instead of an empty object by default r=robwu

https://hg.mozilla.org/mozilla-central/rev/c40d0c42dee6

Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
status-firefox76: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: