1581915 - Turn on DS for all releases in en-US with default pref to match rollout

Status: VERIFIED FIXED

(Firefox :: New Tab Page, task, P1)

Description

[Scott [:thecount] Downe]

Now that the rollout is going good, we should talk about updating the pref in 70 and 71 to match the rollout value.

Comment 1

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: Will need to change default 70 firefox.js pref to match the 69 rollout behavior:

https://searchfox.org/mozilla-central/rev/1d0e84d2ec2843924bc6e5ed6658f93439e12351/browser/app/profile/firefox.js#1317-1322

Comment 2

[Jessilyn Davis]

Scott to land in nightly, Nan to uplift, Gavin to review.

Thanks y'all!

Comment 3

[Scott [:thecount] Downe]

For context, this is the line that needs to be changed:

https://searchfox.org/mozilla-central/source/browser/app/profile/firefox.js#1318

Comment 4

[Scott [:thecount] Downe]

Attachment: Bug 1581915 - Turn on DS pref to match rollout

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e03ccbf78c1e
Turn on DS pref to match rollout r=nanj

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/e03ccbf78c1e

Comment 7

[Nan Jiang [:nanj]]

Comment on attachment 9093411 [details]
Bug 1581915 - Turn on DS pref to match rollout

Beta/Release Uplift Approval Request

• User impact if declined: Users won't be able to use this new design of newtab page in 70.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This enables a feature that was rolled out by Normandy in 69.
• String changes made/needed: None

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

OK, is this something we might describe in a release note?

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9093411 [details]
Bug 1581915 - Turn on DS pref to match rollout

Flip pref for new discovery stream behavior. Fine for uplift for beta 11.

Comment 10

[Jessilyn Davis]

(In reply to Liz Henry (:lizzard) from comment #8)

OK, is this something we might describe in a release note?

Tawanda has been making sure that Pocket + New Tab has been in the past release notes as the experience rolled out to 94% of en-US users with Fx 69: https://www.mozilla.org/en-US/firefox/69.0/releasenotes/

"For our users in the US or using the en-US browser, we are shipping a new “New Tab” page experience that connects you to the best of Pocket’s content."

I'm unsure if we need to say the same thing for Fx 70? Ni'ing Tawanda to keep this on his radar.

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Oh, that's fine then, if it was already rolled out to the majority of users on release and noted, we can leave it at that.

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9f56e21f6e83

Comment 13

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this issue with the latest Firefox Nightly (71.0a1 Build ID - 20190923215658) and latest Firefox Beta (70.0b9 Build ID - 20190923154733) installed, on Windows 10 x64, Arch Linux and Mac 10.14.6. Now, I can confirm that "Discovery Stream" is displayed by default on the "en_US", "en-CA" and "en-GB" Firefox locales, with the "browser.search.region" pref set to "US" or "CA".