Closed Bug 1581931 Opened 2 years ago Closed 1 year ago

Cleanup unused identity popup breakage report view styles

Categories

(Firefox :: Site Identity, task, P3)

Product:
Firefox
Component:
Site Identity
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 76
Tracking Flags:
Tracking Status
firefox76 --- fixed

People

(Reporter: ntim, Assigned: amina.kenessova, Mentored)

Details

(Whiteboard: [privacy-panel][skyline])

Attachments

(1 file)

Bug 1581931 - Remove unused identity popup breakage report view styles. r=nhnt11
47 bytes, text/x-phabricator-request
Details | Review

Some of the CSS involving #identity-popup-* doesn't seem used ever since their UI was moved into the protections panel.

Johann, could someone from your team look into this given that they will be more familiar with what can be removed? It would be nice to not have some dead code lying around :)

Flags: needinfo?(jhofmann)

Yup! Thanks for filing this.

Flags: needinfo?(jhofmann)
Whiteboard: [privacy-panel][skyline]
Priority: -- → P3
Mentor: nhnt11

Here's how I would approach this:

  1. Use the inspector/console to find all elements that have IDs or classes starting with identity-popup. (document.querySelectorAll)
  2. For each one, find CSS rules in the codebase.
  3. After eliminating those, the remaining ones are likely unused rules. Remove them, double-check for sanity, build, test. This should result in a usable patch.

Note that the above process might not work great for dynamically added elements - they might not yet be present in the DOM when we query it. So as an extra step it would be good to search the codebase for identity-popup and see if we have any elements that are dynamically added.

Assignee: nobody → amina.kenessova
Status: NEW → ASSIGNED
Attachment #9134803 - Attachment description: Bug 1581931 - Removed identity-popup-breakageReportView styles. r=nhnt11 → Bug 1581931 - Remove unused identity popup breakage report view styles. r=nhnt11
Pushed by dluca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1d09f9517c32
Remove unused identity popup breakage report view styles. r=nhnt11

https://hg.mozilla.org/mozilla-central/rev/1d09f9517c32

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox76: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76
Summary: Cleanup #identity-popup-* CSS → Cleanup unused identity popup breakage report view styles
You need to log in before you can comment on or make changes to this bug.