1581931 - Cleanup unused identity popup breakage report view styles

Status: RESOLVED FIXED

(Firefox :: Site Identity, task, P3)

Description

[Tim Nguyen :ntim]

Some of the CSS involving #identity-popup-* doesn't seem used ever since their UI was moved into the protections panel.

Comment 1

[Tim Nguyen :ntim]

Johann, could someone from your team look into this given that they will be more familiar with what can be removed? It would be nice to not have some dead code lying around :)

Comment 2

[Johann Hofmann [:johannh]]

Yup! Thanks for filing this.

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Here's how I would approach this:

1. Use the inspector/console to find all elements that have IDs or classes starting with identity-popup. (document.querySelectorAll)
2. For each one, find CSS rules in the codebase.
3. After eliminating those, the remaining ones are likely unused rules. Remove them, double-check for sanity, build, test. This should result in a usable patch.

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

Note that the above process might not work great for dynamically added elements - they might not yet be present in the DOM when we query it. So as an extra step it would be good to search the codebase for identity-popup and see if we have any elements that are dynamically added.

Comment 5

[Amina Kenessova]

Attachment: Bug 1581931 - Remove unused identity popup breakage report view styles. r=nhnt11

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d09f9517c32
Remove unused identity popup breakage report view styles. r=nhnt11

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/1d09f9517c32