"Device Connected" notification sent as another device connects should be reworded to avoid the term "sync"
Categories
(Firefox :: Firefox Accounts, enhancement)
Tracking
()
People
(Reporter: markh, Unassigned)
References
Details
As another device connects to your account, all other devices already connected get a push notification with title "Firefox Sync" and body either "This computer is now syncing with {new-device-name}" (if the new device name is known) or "This computer is now syncing with a new device." (if no name is known). Because this is sent whenever a new device connects to the account, but not necessarily for sync, talking about "sync" isn't going to be accurate once decoupling lands.
Ryan said he would try and get new copy.
(similar, but subtly different to bug 1581980)
|
||
Comment 1•5 years ago
|
||
I also want to flag that changing the circumstances under which this notification appears is not an option (at least not in the short term). Part of the point of this notification is as a security measure, so users have awareness of any unexpected connections to their account. We need to show it at the point where a new devices becomes capable of syncing, regardless of whether or not the user opted to actually enable sync on the new device.
|
||
Comment 2•5 years ago
|
||
Are these the strings in question?
https://hg.mozilla.org/l10n/gecko-strings/file/default/browser/chrome/browser/accounts.properties
Should I pull in the mobile strings too
I'll review with our content folks.
|
Reporter | |
Comment 3•5 years ago
|
||
(In reply to Ryan Feeley [:rfeeley] from comment #2)
Are these the strings in question?
https://hg.mozilla.org/l10n/gecko-strings/file/default/browser/chrome/browser/accounts.properties
Yep - and there are others there which should be changed too - eg, "deviceDisconnectedNotification.title" for when a device is disconnected remotely.
Should I pull in the mobile strings too
It can't hurt - even though Fennec and iOS don't currently have "decouple" plans, they are still affected - eg, they might still report a desktop device "connected to sync" when it didn't. I'm not sure of Fenix has anything like this yet?
Regardless, I don't think we should block the desktop strings while we work out what to do on mobile, so maybe new bugs?
|
||
Comment 4•5 years ago
|
||
Wait, why are we touching Fennec at this point? It's supposed to be removed from code in mozilla-central starting from 71…
Since we're touching old strings, what are the chances of moving them to Fluent in the process?
|
|
Reporter | |
Comment 5•5 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #4)
Wait, why are we touching Fennec at this point?
We might not. I was just pointing out that a message displayed by Fennec will no longer be correct. I've no idea who would make the decision about how bad the now-incorrect message is.
Since we're touching old strings, what are the chances of moving them to Fluent in the process?
Surely that seems even less likely than updating a single string?
|
||
Comment 6•5 years ago
|
||
Just closing the loop on this if we need new strings or no
|
||
Comment 7•5 years ago
|
||
Here is the updated copy for the notifications sent when sync is connected: https://docs.google.com/document/d/1bU2SF1hrGxiaeyMD3pRJAiEfdZ8T4LIW3ZdZriM_WCw/edit?usp=sharing
|
|
Reporter | |
Comment 8•5 years ago
|
||
Doing all of this in bug 1581980
Description
•