Closed Bug 1581989 Opened 1 year ago Closed 1 year ago

Tip results aren't properly accounted for in histogram telemetry

Categories

(Firefox :: Address Bar, defect, P2)

defect
Points:
2

Tracking

()

RESOLVED FIXED
Firefox 71
Iteration:
71.2 - Sept 16 - 29
Tracking Status
firefox71 --- fixed

People

(Reporter: adw, Assigned: adw)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

UrlbarController.recordSelectedResult is called when a result is picked. Bug 1578433 added a new case statement for tips, but we didn't update URLBAR_SELECTED_RESULT_TYPES, so the two histograms at the bottom of that method won't actually be updated. My fault for not realizing the obvious.

We should add a test called browser_UsageTelemetry_urlbar_tip.js modeled on these tests:

Assignee: nobody → adw
Status: NEW → ASSIGNED
Iteration: --- → 71.2 - Sept 16 - 29
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/73e41954d0f7
Properly account for tip results in histogram telemetry. r=harry
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in before you can comment on or make changes to this bug.