Closed Bug 1582039 Opened 3 years ago Closed 3 years ago

Clean up JSContext::runningWithTrustedPrincipals

Categories

(Core :: JavaScript Engine, task, P1)

Product:
Core
Component:
JavaScript Engine
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: jandem, Assigned: jandem)

Details

Attachments

(1 file)

Bug 1582039 - Make JSContext::runningWithTrustedPrincipals() return false if trustedPrincipals() is nullptr. r?luke!
47 bytes, text/x-phabricator-request
Details | Review

It currently returns true if runtime->trustedPrincipals() == nullptr which doesn't seem right.

I think we can simplify by expressing in terms of realm->isSystem() because isSystem is derived from the runtime's trustedPrincipals too.

This is a bit simpler and faster and avoids returning true when
rt->trustedPrincipals is nullptr.

Attachment #9093521 - Attachment description: Bug 1582039 - Use realm->isSystem() in JSContext::runningWithTrustedPrincipals. r?luke! → Bug 1582039 - Use realm->isSystem() in JSContext::runningWithTrustedPrincipals(). r?luke!
Attachment #9093521 - Attachment description: Bug 1582039 - Use realm->isSystem() in JSContext::runningWithTrustedPrincipals(). r?luke! → Bug 1582039 - Use realm->isSystem() in JSContext::runningWithTrustedPrincipals() and rename to JSContext::runningSystemCode(). r?luke!
Priority: -- → P1
Attachment #9093521 - Attachment description: Bug 1582039 - Use realm->isSystem() in JSContext::runningWithTrustedPrincipals() and rename to JSContext::runningSystemCode(). r?luke! → Bug 1582039 - Make JSContext::runningWithTrustedPrincipals() return false if trustedPrincipals() is nullptr. r?luke!
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6fb6e6cf5d94
Make JSContext::runningWithTrustedPrincipals() return false if trustedPrincipals() is nullptr. r=luke

https://hg.mozilla.org/mozilla-central/rev/6fb6e6cf5d94

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.