toolkit/components/search/tests/xpcshell/test_json_cache_good.js and toolkit/components/search/tests/xpcshell/test_json_cache_broken.js fail when run as part of the Thunderbird Xpcshell tests
Categories
(Firefox :: Search, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
1.15 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
These tests were created in bug 1578807. We see:
TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_json_cache_good.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_json_cache_good.js | test_cached_engine_properties - [test_cached_engine_properties : 155] Should have recorded the engines cache as not corrupted - "undefined" == false
TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_json_cache_broken.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_json_cache_broken.js | test_cached_engine_properties - [test_cached_engine_properties : 134] Should have recorded the engines cache as corrupted - "undefined" == true
Mark, can you please give us a tip what we need to do in TB to get them working. Or should they simply be disabled?
Comment 1•5 years ago
|
||
Sounds like Thunderbird hasn't recorded any telemetry for the new scalar. Does Thunderbird not have telemetry enabled, even for tests?
Assignee | ||
Comment 2•5 years ago
|
||
Thanks, Mark. We're working on telemetry in bug 1427877. I'll run the test locally and see what needs to be disabled.
Assignee | ||
Comment 3•5 years ago
|
||
I don't think it makes much sense trying to disable parts of the tests.
Comment 4•5 years ago
|
||
Assignee | ||
Comment 5•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 6•5 years ago
|
||
Thanks, Mark.
Dear Sheriff, this bug came from the Thunderbird product and has an "old-fashioned" patch. Please land it for me.
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/89b9b3aa3aaf
disable test_json_cache_{good|broken}.js for Thunderbird. r=standard8
Comment 8•5 years ago
|
||
(In reply to Jorg K (GMT+2) from comment #6)
Thanks, Mark.
Dear Sheriff, this bug came from the Thunderbird product and has an "old-fashioned" patch. Please land it for me.
Done :)
Comment 9•5 years ago
|
||
bugherder |
Updated•3 years ago
|
Updated•3 years ago
|
Description
•