1582086 - toolkit/components/search/tests/xpcshell/test_json_cache_good.js and toolkit/components/search/tests/xpcshell/test_json_cache_broken.js fail when run as part of the Thunderbird Xpcshell tests

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Jorg K (CEST = GMT+2)]

These tests were created in bug 1578807. We see:
TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_json_cache_good.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_json_cache_good.js | test_cached_engine_properties - [test_cached_engine_properties : 155] Should have recorded the engines cache as not corrupted - "undefined" == false
TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_json_cache_broken.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_json_cache_broken.js | test_cached_engine_properties - [test_cached_engine_properties : 134] Should have recorded the engines cache as corrupted - "undefined" == true

Mark, can you please give us a tip what we need to do in TB to get them working. Or should they simply be disabled?

Comment 1

[Mark Banner (:standard8)]

Sounds like Thunderbird hasn't recorded any telemetry for the new scalar. Does Thunderbird not have telemetry enabled, even for tests?

Comment 2

[Jorg K (CEST = GMT+2)]

Thanks, Mark. We're working on telemetry in bug 1427877. I'll run the test locally and see what needs to be disabled.

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 1582086-disable-tests.patch

I don't think it makes much sense trying to disable parts of the tests.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 9093741 [details] [diff] [review]
1582086-disable-tests.patch

Review of attachment 9093741 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/search/tests/xpcshell/xpcshell.ini
@@ +69,2 @@
>  [test_json_cache_good.js]
> +skip-if = appname == "thunderbird"

You might want to add a comment about why these are disabled, and a bug number if you're planning on re-enabling these later once you've got telemetry up and running.

Comment 5

[Jorg K (CEST = GMT+2)]

Attachment: 1582086-disable-tests.patch - with comments

Comment 6

[Jorg K (CEST = GMT+2)]

Thanks, Mark.

Dear Sheriff, this bug came from the Thunderbird product and has an "old-fashioned" patch. Please land it for me.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/89b9b3aa3aaf
disable test_json_cache_{good|broken}.js for Thunderbird. r=standard8

Comment 8

[Andreea Pavel [:apavel]]

(In reply to Jorg K (GMT+2) from comment #6)

Thanks, Mark.

Dear Sheriff, this bug came from the Thunderbird product and has an "old-fashioned" patch. Please land it for me.

Done :)

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/89b9b3aa3aaf